Java method overload

Question

I have 2 alternatives to implement a calculation method, and I am wondering what would be the better approach.

The method needs some int and double parameters and (in some cases) a special flag to do some different calculation.

In the first example, I could call the method with 'calculateFoo(1, 2.0d)' to have the boolean flag == FALSE.

In the second example, I always have to set the boolean flag (even if I do not need it)

Method 1: (here I'm using the '...' as an 'method overloading' parameter)

public SomeObject calculateFoo(int pIntValue, double pDoubleValue, boolean... pDoSpecialStuff) {

    if (pDoSpecialStuff.length == 0 || pDoSpecialStuff[0] == false) {
        // method was called without boolean flag or boolean flag was set to FALSE

        // do some calculation stuff
        // ...
    } else {
        // method was called with boolean flag == TRUE

        // do some other calculation stuff
        // ...
    }

    return SomeObject; 
}

Method 2: (this is the 'common' approach)

public SomeObject calculateFoo(int pIntValue, double pDoubleValue, boolean pDoSpecialStuff) {

    if (pDoSpecialStuff == false) {
        // method was called with boolean flag == FALSE

        // do some calculation stuff
        // ...
    } else {
        // method was called with boolean flag == TRUE

        // do some other calculation stuff
        // ...
    }

    return SomeObject; 
}

Instead of using flags to determine "what to do" you should have multiple methods - one method - one action. It's object-oriented approach. Flags are generally ugly. — omnomnom
– omnomnom, Commented Sep 28, 2011 at 8:01

Dapeng · Accepted Answer · 2011-09-28 08:50:03Z

2

both your methods have code smell, boolean flags suck

here is my suggestion

public SomeObject calculateFoo(int pIntValue, double pDoubleValue) {
    // normal calculation here 
}

public SomeObject calculateFooSpecial(int pIntValue, double pDoubleValue) {
    // special calculation here 
}

answered Sep 28, 2011 at 8:50

Dapeng

1,71613 silver badges25 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

michael667 Over a year ago

+1, and both methods could call a third, private method which contains code common to both calculations

Rinke · Accepted Answer · 2011-09-28 08:18:02Z

1

Consider the following pattern:

public ResultType calcFoo( int i, double d ) {
    return calc( i, d, false );
}

public ResultType calcFoo( int i, double d, boolean flag ) {
    if( flag ) {
        ...
        return result;
    }
    else {
        ...
        return result;
    }
}

Generally it's better to use an enum instead of a boolean flag. It makes your code more readable and is just as fast.

I noticed you considered using varargs. If you want to use more flags consider using an EnumSet to pass a set of flags to the method. If you want to pass 0 or 1 flags, varargs is even more definitely an antipattern.

answered Sep 28, 2011 at 8:18

Rinke

6,3864 gold badges44 silver badges56 bronze badges

Comments

Thomas · Accepted Answer · 2011-09-28 08:02:33Z

1

Do the second variant as it is more explicit. Varargs would allow you to pass more than one boolean which are then not used. Better you explicitly define the interface using a single boolean.

If you want to have a default for the boolean flag use another overload:

public SomeObject calculateFoo(int pIntValue, double pDoubleValue) {
   return calculateFoo(pIntValue, pDoubleValue, false);
}

answered Sep 28, 2011 at 8:02

Thomas

88.9k13 gold badges126 silver badges162 bronze badges

Comments

Andrey Atapin · Accepted Answer · 2011-09-28 08:05:48Z

0

I would define another one method with just two parameter to perform default calculation.

public SomeObject calcFoo(int, double) {
    ....
}

public SomeObject calcFoo(int i, double d, boolean b) {
    if(b) {
        ....
    } else {
        return calcFoo(i, d);
    }
}

answered Sep 28, 2011 at 8:05

Andrey Atapin

8,0153 gold badges31 silver badges34 bronze badges

Collectives™ on Stack Overflow

Java method overload

4 Answers 4

1 Comment

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

1 Comment

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related