How to add parameter to a family in Revit using Revit API in C#?

Question

I am trying to add a parameter to a Revit family. When I open the Revit Family document and execute the code below in a macro, I get this error:

System.Exception: Document regeneration failed. at MacroModule.executeMacro_(MacroModule*, AString* MacroName) at MacroModule.executeMacro_(MacroModule*, AString* ) at UIMacroGeneralManager.runMacro(UIMacroGeneralManager*, MacroModule* pModule, AString* macroName)

Any idea how to solve this issue?

public void FamilyInstanceParameters()
{
    Document document = this.ActiveUIDocument.ActiveView.Document;
    if (!document.IsFamilyDocument)
    {
        TaskDialog.Show("Info", "This is not a FamilyDocument");
    }
    else
    {
        try
        {
            Transaction transaction = new Transaction(document);
            transaction.Start("Param");

            // Get the family document category
            Family family = document.OwnerFamily;
            Category category = family.FamilyCategory;

            FamilyType familyType = document.FamilyManager.NewType("New Type A");
            document.FamilyManager.CurrentType = familyType;


            // Parameter group
            BuiltInParameterGroup builtInParamGroup = BuiltInParameterGroup.PG_IDENTITY_DATA;


            document.Regenerate();
            FamilyParameter familyParameter = document.FamilyManager
               .AddParameter("parameterName", builtInParamGroup, category, false);

            document.FamilyManager.Set(familyParameter, "parameterValue");

            transaction.Commit();
            transaction.Dispose();
        }
        catch (Exception ex)
        {
            throw new Exception(ex.Message);
        }
    }
}

Jeremy Tammik · Accepted Answer · 2022-12-02 06:59:29Z

1

Run your code in the debugger and determine exactly which line is causing the problem. If it is the call to document.Regenerate, maybe it can simply be skipped. For numerous detailed solutions, please search the Revit API discussion forum for add family parameter.

edited Dec 2, 2022 at 6:59

answered Dec 2, 2022 at 6:54

Jeremy Tammik

8,2962 gold badges14 silver badges18 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Ranj Over a year ago

Thank you for your reply. The error occurs at "FamilyParameter familyParameter = document.FamilyManager .AddParameter("parameterName", builtInParamGroup, category, false);". I suspect that something other than the code might be the problem.

Ranj · Accepted Answer · 2022-12-02 08:46:48Z

I solved the issue by using the below method overload:

public FamilyParameter AddParameter( string parameterName, ForgeTypeId groupTypeId, ForgeTypeId specTypeId, bool isInstance )

public void FamilyInstanceParameters()
{
    Document document = this.ActiveUIDocument.ActiveView.Document;
    if (!document.IsFamilyDocument)
    {
        TaskDialog.Show("Info", "This is not a FamilyDocument");
    }
    else
    {
        try
        {
            Transaction transaction = new Transaction(document);
            transaction.Start("Param");

            // Get the family document category
            Family family = document.OwnerFamily;
            Category category = family.FamilyCategory;

            FamilyType familyType = document.FamilyManager.NewType("New Type A");
            document.FamilyManager.CurrentType = familyType;


            // ParameterName en value
            string parameterName = "parameterNameLength";
            int parameterValue = 20;

            FamilyParameter familyParameter = document.FamilyManager.AddParameter(parameterName: parameterName, groupTypeId: GroupTypeId.Constraints, specTypeId: SpecTypeId.Length, isInstance: false);


            document.FamilyManager.Set(familyParameter, parameterValue);

            transaction.Commit();
            transaction.Dispose();
        }
        catch (Exception ex)
        {
            throw new Exception(ex.Message);
        }
    }
}

Marek Trawczynski · Accepted Answer · 2023-01-11 14:13:04Z

This is how to add text parameter

    public void AddParameter(Document familyDoc)
    {
        using(Transaction tx = new Transaction(familyDoc, "AddParameter"))
        {
            tx.Start();
            
            familyDoc.FamilyManager.NewType("New Type A"); //add new type - "new type" becomes current type
            FamilyParameter familyParameter = familyDoc.FamilyManager.AddParameter("parameterName", GroupTypeId.IdentityData, SpecTypeId.String.Text, false); //method overload to add text parameter
            familyDoc.FamilyManager.Set(familyParameter, "parameterValue");
            //familyDoc.FamilyManager.SetFormula(familyParameter, "\"parameterValue\"");
            
            tx.Commit();
        }
    }

Collectives™ on Stack Overflow

How to add parameter to a family in Revit using Revit API in C#?

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related