Optimize loop in ASP.Net / C#

Question

I wrote a loop to display each line one by one from a List of string. The problem is that the list contains more that 45,000 lines and its taking a lot of time to create the page for displaying.

Can someone please help in optimizing the code !

        List<string> OverrrideLog = lc.getOverrideLog();
        List<string> AccessLog = lc.getAccessLog();

        foreach (string s in OverrrideLog)
            lblOverrideLog.Text += s + "<br/>";

        foreach (string s in AccessLog)
            lblAccessLog.Text += s + "<br/>";

Here lblOverrideLog and lblAccessLog are literals and each list has more than 22,000 lines.

@CD No, String.Join Method (String, IEnumerable<String>). He already has a List` — xanatos
– xanatos, Commented Sep 1, 2011 at 11:44
read this article codeproject.com/KB/cs/StringBuilder_vs_String.aspx — Nahum
– Nahum, Commented Sep 1, 2011 at 12:05

Community · Accepted Answer · 2017-05-23 12:29:09Z

5

You can use the String.Join Method (String, IEnumerable):

List<string> OverrrideLog = lc.getOverrideLog();
List<string> AccessLog = lc.getAccessLog();

lblOverrideLog.Text = String.Join("<br />", OverrrideLog);
lblAccessLog.Text = String.Join("<br />", AccessLog);

(See also String.Join vs. StringBuilder: which is faster?)

edited May 23, 2017 at 12:29

CommunityBot

11 silver badge

answered Sep 1, 2011 at 11:43

CD..

74.4k25 gold badges160 silver badges170 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Maverick Over a year ago

Thanks a lot :) I used this one and the one answered by SBlackler. Both are working great !

Stuart Blackler Over a year ago

Admittedly, I didn't know about String.Join in this way +1

Stuart Blackler · Accepted Answer · 2011-09-01 11:48:39Z

4

Untested but try this:

List<string> OverrrideLog = lc.getOverrideLog();
List<string> AccessLog = lc.getAccessLog();

StringBuilder sb = new StringBuilder();
StringBuilder sb2 = new StringBuilder();

foreach(var el in OverrrideLog)
{
  sb.Append(el);
  sb.Append(" <br />");
}

foreach(var el in AccessLog)
{
  sb2.Append(el);
  sb2.Append(" <br />");
}

lblOverrideLog.Text = sb.ToString();
lblAccessLog.Text = sb2.ToString();

Edit:

woops, put val instead of var

edited Sep 1, 2011 at 11:48

answered Sep 1, 2011 at 11:38

Stuart Blackler

3,7825 gold badges39 silver badges60 bronze badges

1 Comment

Maverick Over a year ago

Thanks a lot :) I used this one and the one answered by CD. Both are working great

George Duckett · Accepted Answer · 2011-09-01 11:34:04Z

0

You should be using a StringBuilder.

Concatenating strings like you are creates thousands of temporary ones in memory.

answered Sep 1, 2011 at 11:34

George Duckett

32.6k12 gold badges101 silver badges167 bronze badges

1 Comment

Marco Over a year ago

George, sorry: I red your comment and started to write an answer... but you are the first, so do you prefer I delete my answer? :)

shenhengbin · Accepted Answer · 2011-09-01 11:43:20Z

0

for a exsample

            OverrrideLog.ForEach(x=>{
                if (sbOverrideLog.Length > 0)
                    sbOverrideLog.Append("<br />");

                sbOverrideLog.Append(x);
            });

            AccessLog.ForEach(x =>
            {
                if (sbAccessLog.Length > 0)
                    sbAccessLog.Append("<br />");

                sbAccessLog.Append(x);
            });

answered Sep 1, 2011 at 11:43

shenhengbin

4,2941 gold badge26 silver badges33 bronze badges

Collectives™ on Stack Overflow

Optimize loop in ASP.Net / C#

4 Answers 4

2 Comments

1 Comment

1 Comment

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

2 Comments

1 Comment

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related