C# loop optimization

Question

i have this loop and it loops for large count like 30 000 times at least
i am looking for some way to improve it's performance
DbRecordDictionary is derived from DictionaryBase class
here is the loop:

ArrayList noEnter = new ArrayList();
DbRecordDictionary oldArray = new DbRecordDictionary();
DbRecordDictionary userArray = new DbRecordDictionary();
DbRecordDictionary result = null;
foreach (string key in keys)
{
    if (noEnter.Contains(key))
    { //may need cast!
        if (count < 1)
            result.Add(key, userArray[key]);
        else if (oldArray.Count == 0)
            break;
        else if (oldArray.Contains(key))
            result.Add(key, userArray[key]);
    }                
}

Please fix the formatting. Don't use `. Just indent each line by at least four spaces. — dandan78
– dandan78, Commented Nov 25, 2010 at 10:27
Don't use <code> tags. They don't work. Select your code and press the 010101 button instead — Armen Tsirunyan
– Armen Tsirunyan, Commented Nov 25, 2010 at 10:27
you might consider including noEnter, userArray, oldArray declarations.. — Peter
– Peter, Commented Nov 25, 2010 at 10:30
@Armen: can you believe I dumbly started scanning my keyboard for this mythical 010101 button? — xtofl
– xtofl, Commented Nov 25, 2010 at 10:31
noEnter is array list and the rest are derived from Dictionarybase class — Abd
– Abd, Commented Nov 25, 2010 at 10:39

leppie · Accepted Answer · 2010-11-25 10:29:08Z

2

You may want to use a Dictionary/Hashset for oldArray, but else there is not much you can do. Also noEnter if that is an array.

answered Nov 25, 2010 at 10:29

leppie

118k18 gold badges201 silver badges300 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Guffa · Accepted Answer · 2010-11-25 10:36:42Z

1

From what I can see, the variable count or the oldArray never changes during the loop, so you can place those condition outside the loop, and make two different loops.

if (count < 1) {
  foreach (string key in keys) {
    if (noEnter.Contains(key)) {
      result.Add(key, userArray[key]);
    }
  }
} else if (oldArray.Count == 0) {
  // no data
} else {
  foreach (string key in keys) {
    if (noEnter.Contains(key)) {
      if (oldArray.Contains(key)) {
        result.Add(key, userArray[key]);
      }
    }                
  }
}

The collections noEnter and oldArray should be dictionaries, otherwise you will be spending a lot of execution time in the Contains calls.

answered Nov 25, 2010 at 10:36

Guffa

703k111 gold badges760 silver badges1k bronze badges

Comments

Ian Ringrose · Accepted Answer · 2010-11-25 10:51:24Z

1

If noEnter has more then about 10 items in it, then use a Dictionary rathern then a List/Array for it. As a Dictionary can look up a item without having to look at all the items, when an List/Array has to loop over all items.

Otherwise consider shorting "keys" and "oldArray" and then proforming a "merge" on them. Look at the code for a "merge sort" to see how to do the merge. (This would need carefull profiling)

answered Nov 25, 2010 at 10:51

Ian Ringrose

52.1k58 gold badges218 silver badges325 bronze badges

Comments

Dean Chalk · Accepted Answer · 2010-11-25 10:56:19Z

0

try this

(from k in keys
     where noEnter.Contains(k) &&
           oldArray.Count > 0 &&
           count < 1 &&
           oldArray.Contains(k)
     select k)
        .ToList()
        .ForEach(k => result.Add(k, userArray[k]));

answered Nov 25, 2010 at 10:56

Dean Chalk

20.5k6 gold badges66 silver badges95 bronze badges

Comments

Peter · Accepted Answer · 2010-11-25 11:32:02Z

0

Small small optimization could be using generics ArrayList noEnter = new ArrayList(); would be List noEnter = new List(); and DbRecordDictionary would inherit Dictonary instead of DictionaryBase.

im not 100% sure that you would gain performance but you will use a more modern c# style.

answered Nov 25, 2010 at 11:32

Peter

38.9k39 gold badges151 silver badges213 bronze badges

Collectives™ on Stack Overflow

C# loop optimization

5 Answers 5

Comments

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related