empty string condition not working with jQuery [closed]

Question

Closed. This question needs debugging details. It is not currently accepting answers.

Edit the question to include desired behavior, a specific problem or error, and the shortest code necessary to reproduce the problem. This will help others answer the question.

Closed 3 years ago.

Improve this question

retrievedID is a string returned by window localStorage property in my code as:

$(function () {
            var retrievedID = localStorage.getItem('navitemID');
            if ($(retrievedID).val() !== '') {
                $('.navbar-nav li').removeClass('active');
                var myID = "#" + retrievedID;
                $(myID).addClass('active');
            }
        });

if statement in this code isn't working as expected because despite having an empty string inside recievedID variable, code is still entering inside the condition and executing.

Can someone please help. Thanks in advance.

What exactly is the value of $(retrievedID).val()? Anything other than an empty string will satisfy the condition. — phuzi
– phuzi, Commented May 23, 2022 at 8:25
So what is console.log($(retrievedID).val()); is pointing out? — Thallius
– Thallius, Commented May 23, 2022 at 8:25
@Thallius: $(retrievedID).val() in console is coming as undefined — Oxin
– Oxin, Commented May 23, 2022 at 8:30
@phuzi: if condition in Mandeep's solution is always coming as true for all values and hence code inside the if condition is never getting to execute. — Oxin
– Oxin, Commented May 23, 2022 at 9:37

Mandeep Singh · Accepted Answer · 2022-05-23 08:43:54Z

1

You can also check undefined type, add to if condition

$(function () {
            var retrievedID = localStorage.getItem('navitemID');
            if ($(retrievedID).val() !== '' ||  typeof $(retrievedID).val() !== "undefined" ) {
                $('.navbar-nav li').removeClass('active');
                var myID = "#" + retrievedID;
                $(myID).addClass('active');
            }
        });

answered May 23, 2022 at 8:43

Mandeep Singh

5755 silver badges15 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Thallius Over a year ago

Maybe you should change || to &&

joronimo Over a year ago

You should leave out the quotes around undefined, for more information developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/…

phuzi Over a year ago

@joronimo typeof returns a string which is why the test is against "undefined" and not undefined

Collectives™ on Stack Overflow

empty string condition not working with jQuery [closed]

1 Answer 1

3 Comments

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Related