Objective-C error while implementing class?

Question

I have this class

#import <Foundation/Foundation.h>

@interface SubscriptionArray : NSObject{
    NSString *title;
    NSString *source;
    NSString *htmlUrl;
}

@property (nonatomic,retain) NSString *title;
@property (nonatomic,retain) NSString *source;
@property (nonatomic,retain) NSString *htmlUrl;

@end

and the implementation file is this one:

#import "SubscriptionArray.h"

@implementation SubscriptionArray
@synthesize title,source,htmlUrl;

-(void)dealloc{
    [title release];
    [source release];
    [htmlUrl release];
}

@end

When I use the class like in this example I get an EXEC_BAD_ACCESS error:

  for (NSDictionary *element in subs){
            SubscriptionArray *add;
            add.title=[element objectForKey:@"title"];   //ERROR Happens at this line
            add.source=[element objectForKey:@"htmlUrl"];
            add.htmlUrl=[element objectForKey:@"id"];
            [subscriptions addObject:add];


        }

Can someone help me? P.S. Subscriptions is a NSMutableArray

Suhail Patel · Accepted Answer · 2011-08-27 15:39:13Z

5

You need to allocate your SubscriptionArray object like so: SubscriptionArray *add = [[SubscriptionArray alloc] init];

Your for loop will therefore look something like this:

for (NSDictionary *element in subs){
        SubscriptionArray *add = [[SubscriptionArray alloc] init];
        add.title=[element objectForKey:@"title"];
        add.source=[element objectForKey:@"htmlUrl"];
        add.htmlUrl=[element objectForKey:@"id"];
        [subscriptions addObject:add];
        [add release];
}

edited Aug 27, 2011 at 15:39

answered Aug 26, 2011 at 15:07

Suhail Patel

13.7k2 gold badges46 silver badges49 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

paul_1991 Over a year ago

thank you for the answer, I correct my code and Now I get this error:2011-08-26 17:14:18.102 NewsPad[1204:15203] *** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '-[__NSCFSet objectAtIndex:]: unrecognized selector sent to instance 0x7eb2cb0' what does it means? what can I do?

Suhail Patel Over a year ago

It seems your element variable refers to an NSSet rather than an NSDictionary. To understand more, we'd need to see the code where subs is defined.

jscs Over a year ago

You need to put [add release]; at the end of the loop, after adding add to subscriptions. @paul

Suhail Patel Over a year ago

@Josh Yep totally forgot about the release. Added it in to the code :)

Oscar Gomez · Accepted Answer · 2011-08-26 15:06:09Z

2

You need to initialize your SubscriptionArray. i.e.

SubscriptionArray *add = [SubscriptionArray new];

answered Aug 26, 2011 at 15:06

Oscar Gomez

18.5k14 gold badges88 silver badges119 bronze badges

Collectives™ on Stack Overflow

Objective-C error while implementing class?

2 Answers 2

4 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

4 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related