Why won't my setVisibility View display correctly?

Question

I'm trying display a Relative Layout based on a checkbox preference. Right now, no matter what state the checkbox is in, the layout is gone.

final RelativeLayout unreadCount = (RelativeLayout) findViewById(R.id.header_navigation);
            if(_preferences.getBoolean(UNREAD_COUNT_ENABLED_KEY, false)){
                unreadCount.setVisibility(View.VISIBLE);
            }else{
                if(_preferences.getBoolean(UNREAD_COUNT_ENABLED_KEY, true)){
                unreadCount.setVisibility(View.GONE);
            }
        }

<RelativeLayout
    android:id="@+id/header_navigation"
    android:layout_width="wrap_content"
    android:layout_height="wrap_content" 
    android:gravity="center"
    android:padding="2dp">
    <Button
        android:id="@+id/previous_button" 
        android:layout_height="wrap_content"
        android:layout_width="wrap_content"
        android:layout_alignParentLeft="true"
        android:layout_alignParentTop="true"
        android:hapticFeedbackEnabled="true"
        android:background="@drawable/btn_prev_arrow" />
    <TextView
        android:id="@+id/notification_count_text_view"
        android:layout_height="50dip"  
        android:layout_width="wrap_content" 
        android:layout_alignParentTop="true"
        android:layout_toRightOf="@+id/previous_button" 
        android:layout_toLeftOf="@+id/next_button"
        android:gravity="center"
        android:focusable="true" 
        android:clickable="true"
        android:textAppearance="?android:attr/textAppearanceMedium" 
        android:textColor="@color/white"
        android:text="0/0"/>
    <Button
        android:id="@+id/next_button" 
        android:layout_height="wrap_content"
        android:layout_width="wrap_content"
        android:layout_alignParentRight="true"
        android:layout_alignParentTop="true"
        android:hapticFeedbackEnabled="true"
        android:background="@drawable/btn_next_arrow"/>
</RelativeLayout>

Have you put your code into debug to make sure it's making it into the if statement at all? Also, what's the visibility attribute set as in the XML? — hooked82
– hooked82, Commented Aug 24, 2011 at 22:56
@hooked82 My if statement working and I've tried adding a visibility attribute set to "visible" in my layout, but nothing changed. — adneal
– adneal, Commented Aug 24, 2011 at 23:18

John Leehey · Accepted Answer · 2011-08-24 22:58:38Z

2

Your code is flawed - no matter what the checkbox state is, the unreadCount.setVisibility(View.GONE); line will never be run. If the checkbox is checked, the beginning section of the if statement will be run. If it is not checked, the second nested if will skip over that line. You need to take out the second nested if:

final RelativeLayout unreadCount = (RelativeLayout) findViewById(R.id.header_navigation);

if(_preferences.getBoolean(UNREAD_COUNT_ENABLED_KEY, false)){
   unreadCount.setVisibility(View.VISIBLE);
}else{
   unreadCount.setVisibility(View.GONE);
}

Aside from this snippet, there is probably a flaw in your layout that is causing the view not to be shown. Try testing it with a setVisibility(View.VISIBLE) line outside of any conditional statements to see if it shows, then I'd check your layout or post it here.

answered Aug 24, 2011 at 22:58

John Leehey

22.3k9 gold badges63 silver badges90 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

adneal Over a year ago

I tried adding "android:visibility="visible" under my Relative Layout bracket and nothing changed. If I remove View.GONE altogether the layout shows, so I'm not sure where my problem lies.

John Leehey Over a year ago

Is there anywhere else you set the visibility of your view, or is the code you posted different than the code you have? It shouldn't matter what you do to the View.GONE line because that line will never be run. If you have updated to use my code above, then it must mean that either the preference for UNREAD_COUNT_ENABLED_KEY is unchecked, UNREAD_COUNT_ENABLED_KEY is using the wrong key, or the preference is not a checkbox preference.

adneal Over a year ago

I figured it out. I hadn't added my relative layout as a property.

Collectives™ on Stack Overflow

Why won't my setVisibility View display correctly?

1 Answer 1

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related