Simply if else condition in JavaScript/es6

Question

How do I make this if else more simple.

if (!request) {
  return 'no request';
} else {
  if (loading === '404') {
    return 'rejected';
  }
  if (loading === '200' && !array1.length) {
    return 'fulfilled';
  }
}

if any ternary operator then how can I make it

What's wrong with the current code? It's clear as is, you don't need to minify your developement code. — Teemu
– Teemu, Commented Jan 7, 2022 at 16:05
I don't think it can be much simpler than this. Each condition is different, and each return statement is different — Jeremy Thille
– Jeremy Thille, Commented Jan 7, 2022 at 16:05
not all paths lead to a returned value so not sure how a ternary would work. — epascarello
– epascarello, Commented Jan 7, 2022 at 16:06
Cannot make it simpler, but you miss a return in the else condition. What if all the condition is not fullfilled? I think you should return something if nothing fullfilled. — ikhvjs
– ikhvjs, Commented Jan 7, 2022 at 16:06
The code is working I guess, so the better site to ask help would be codereview.stackexchange.com. Other than that if you have return in if you don't need else this convention would flatten your code. — Yury Tarabanko
– Yury Tarabanko, Commented Jan 7, 2022 at 16:08

Nina Scholz · Accepted Answer · 2022-01-07 16:06:38Z

3

You could omit else part, because you return if true.

if (!request) return 'no request';
if (loading === '404') return 'rejected';
if (loading === '200' && !array1.length) return 'fulfilled';

answered Jan 7, 2022 at 16:06

Nina Scholz

388k26 gold badges367 silver badges417 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Zahid Hasan · Accepted Answer · 2022-01-07 16:11:57Z

0

You can also simply do this with the ternary operator. Hope the below code will you.

!request ? 'no request' : loading === '404' ? 'rejected' : 'fullfilled'

answered Jan 7, 2022 at 16:11

Zahid Hasan

5975 silver badges12 bronze badges

2 Comments

NullDev Over a year ago

Nested ternaries are almost always bad practice though.

Mary N Over a year ago

@NullDev you should explain why do you believe smth is bad practice.

Vignesh · Accepted Answer · 2022-01-07 16:15:12Z

0

You can use if-elseif-else statement

if(!request) return 'no request'
else if(loading === '404') return 'rejected'
else if(loading === '200' && !array.length) return 'fulfilled'

answered Jan 7, 2022 at 16:15

Vignesh

3123 silver badges12 bronze badges

1 Comment

Yury Tarabanko Over a year ago

There is no need to use else if if you have return. If you remove redundant code the answer would be identical to the very first one.

Peter Seliger · Accepted Answer · 2022-01-07 17:07:17Z

0

one might consider ...

{
  // ...
  return ((!request && 'no request')
    || (loading === '404' && 'rejected')
    || (loading === '200' && !array1.length && 'fulfilled')
    || undefined // or 'failure' // or 'not fulfilled'
  );
}

... or ...

{
  // ...
  let returnValue = (!request && 'no request')
    || (loading === '404' && 'rejected')
    || (loading === '200' && !array1.length && 'fulfilled')
    || undefined; // or 'failure'; // or 'not fulfilled';
  
  // do more stuff ...
  // ...
  // ... maybe even change `returnValue` again.
  
  return returnValue;      
}

edited Jan 7, 2022 at 17:07

answered Jan 7, 2022 at 16:54

Peter Seliger

13.5k3 gold badges31 silver badges45 bronze badges

2 Comments

Julian A Avar C Over a year ago

I think that this style is very useful in more standard code bases: Like if you have 5+ of loading, and they all return a string, then this code is perfect. If those three if statements are all there is however, then this code is extremely difficult to dig through. Just an opinion.

Nina Scholz Over a year ago

btw, no need to wrap logical AND expressions with parentheses. the main difference to the question is the place. if statements could be at any place, but the return statement unconditionally ends the function.

Julian A Avar C · Accepted Answer · 2022-01-07 17:39:36Z

-1

if (request) {
  switch (loading) {
    case "404":
      return "rejected";
    case "200":
      if (!array1.length) return "filfilled";
      break;
  }
} else {
  return "no request";
}

I think a switch statement is better here considering that you may get more cases.

edited Jan 7, 2022 at 17:39

answered Jan 7, 2022 at 16:15

Julian A Avar C

89810 silver badges29 bronze badges

1 Comment

Yury Tarabanko Over a year ago

Please no, for the sake of cyclomatic complexity :)

Collectives™ on Stack Overflow

Simply if else condition in JavaScript/es6

5 Answers 5

Comments

2 Comments

1 Comment

2 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

2 Comments

1 Comment

2 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related