Spring Boot, The object is not deleted eventhough delete command is being executed

Question

I have customers and books in my table. When a customer is deleted I also want book's availability to be set to available. When I only execute the code without first 3 lines of the method(setting availability to the available) it works perfectly fine and deletes the customer object. But when I add those lines to set books available then nothing happens and customer object stays without any removal.

@GetMapping("/customers/delete/{id}")
public String deleteCustomer(@PathVariable("id") int theId, Model model){
    Customer c1 = CustomerService.getSingleCustomer(theId).get();
    for(int i=0;i<c1.getRentedBooks().size();i++){
        c1.getRentedBooks().get(i).availability="Available";
    }
   

    CustomerService.delete(theId);
    return "redirect:/customer/listofcustomers";
}

For starters this code needs to be in a service not in a controller. Second do you have a bi-directional relationship between book and customer? If so the update on book will re-instate the customer. — M. Deinum
– M. Deinum, Commented Dec 16, 2021 at 12:43
I get the idea that any update will re-instate the customer but the thing is I do update operations before deleting the customer. So in my perspective nothing should change considering the order of the execution. What is the correct way of doing what I aimed for. Thank you in advance for your comment — ahmetsaim
– ahmetsaim, Commented Dec 16, 2021 at 12:53
Everything is flushed at once instead of single operations. What you should do is set the customer to null in the books, change the status and delete the user. And as stated this code should be in service method not a controller method. YOur controller should call that transactional service method. — M. Deinum
– M. Deinum, Commented Dec 16, 2021 at 12:58
Is CustomerService a class or a poor variable identifier?? ;(;(;( — xerx593
– xerx593, Commented Dec 16, 2021 at 13:36
Hey Deinum, The problem was I never set Book's customer attribute to null. I have moved my code to service method and set customer to null while deletion as you have told me. It worked like a charm. Thanks for taking your time and helping me out — ahmetsaim
– ahmetsaim, Commented Dec 16, 2021 at 14:14

Azadi Yazdani · Accepted Answer · 2021-12-16 18:35:11Z

1

If field availability in Book class is private, use:

c1.getRentedBooks().get(i).setAvailability("Available");

answered Dec 16, 2021 at 18:35

Azadi Yazdani

2851 silver badge9 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Spring Boot, The object is not deleted eventhough delete command is being executed

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related