C++ Inheritance with templates undefined reference error

Question

I want to implement a base class with multiple children.

Base Class

    template <typename T>
    class Trigger
    {
    protected:
        T threshold;
        Trigger(T a_threshold) : threshold(std::pow(10, a_threshold / 20)){};
    public:
        void setThreshold(T a_threshold)
        {
            threshold = std::pow(10, a_threshold / 20);
        }
        virtual bool operator()(const T &first, const T &second) const;
        virtual ~Trigger() = default;
    };

Derived Class

    template <typename T>
    class ZeroCrossingRisingTrigger : public Trigger<T>
    {
    public:
        ZeroCrossingRisingTrigger(void) : Trigger<T>(0.){};

        bool operator()(const T &first, const T &second) const override
        {
            return (first <= 0) & (second > 0);
        }
    };

Usage in the main file

#include "Trigger.hpp"
int main([[maybe_unused]] int argc, [[maybe_unused]] char const *argv[])
{
    Trigger::ZeroCrossingRisingTrigger<double> trig;
    return 0;
}

But on I get the following error when I try to compile it:

(...): undefined reference to `Trigger::Trigger::operator()(double const&, double const&) const'

I don't understand why I get this error because I implemented the operator exactly as written in the error message.

virtual and template don't mix very well together stackoverflow.com/questions/2354210/… — Alessandro Teruzzi
– Alessandro Teruzzi, Commented Nov 8, 2021 at 8:21
Thank you for your comments. Would you recommend to implement it using CRTP? — SpiRelli
– SpiRelli, Commented Nov 8, 2021 at 8:37
Either provide an implementation in the base class or make it pure (virtual bool operator()(const T &first, const T &second) const = 0;) — molbdnilo
– molbdnilo, Commented Nov 8, 2021 at 8:53

Ton van den Heuvel · Accepted Answer · 2021-11-08 08:55:11Z

1

You have not defined an implementation for operator() for Trigger<T>. An option would be to make Trigger an abstract base class by making the operator member function a pure virtual function:

virtual bool operator()(const T &first, const T &second) const = 0;

Alternatively, you can provide an empty implementation.

On a side-note, in the constructor of ZeroCrossingRisingTrigger you pass 0.0 as an argument for the base class constructor. This sort of hints there is no need for ZeroCrossingRisingTrigger to be templated itself, unless you want to control the type of the 0.0 literal from the outside.

answered Nov 8, 2021 at 8:55

Ton van den Heuvel

10.6k6 gold badges49 silver badges92 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

C++ Inheritance with templates undefined reference error

Base Class

Derived Class

Usage in the main file

1 Answer 1

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

Base Class

Derived Class

Usage in the main file

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related