Using PHP variables in document header

Question

I am trying to get php variables inserted into the code below. When the document download pop up shows up it shows $filename instead of the actual file name. How can i achieve this?

code:

<?php
header('Content-disposition: attachment; filename=$filename');
header('Content-type: $type');
readfile('$filename');
?>

lonesomeday · Accepted Answer · 2011-07-28 13:32:38Z

3

You're using single quotes. Variables inside string literals using single quotes are not evaluated. Use concatenation or double quotes instead.

<?php
header("Content-disposition: attachment; filename=$filename"); // double quotes
header('Content-type: ' . $type); // concatenation
readfile($filename); // no quotes needed
?>

See the PHP manual page for the String type.

answered Jul 28, 2011 at 13:32

lonesomeday

239k54 gold badges330 silver badges329 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

KPO Over a year ago

it works but now i get this error: Couldn’t open the file. It may be corrupt or a file format that Preview doesn’t recognize.

lonesomeday Over a year ago

@KPO Well, you'll have to figure out what you're sending wrong, then. That's a different question.

user562854 · Accepted Answer · 2011-07-28 13:33:38Z

2

You don't need quotes here, just use

header('Content-disposition: attachment; filename='.$filename);
header('Content-type: '.$type);
readfile($filename);

answered Jul 28, 2011 at 13:33

user562854

Comments

Griwes · Accepted Answer · 2011-07-28 13:32:25Z

1

Use ", not ', to get variables' values instead of names. When you use ", variables are parsed (to parse array elements it is required to use { and }, but I'm sure you'll find it out when you will need it).

answered Jul 28, 2011 at 13:32

Griwes

9,0892 gold badges47 silver badges71 bronze badges

Comments

minichate · Accepted Answer · 2011-07-28 13:32:58Z

1

Use double-quotes: " instead of single quotes: '

answered Jul 28, 2011 at 13:32

minichate

1,97413 silver badges17 bronze badges

Comments

Karoly Horvath · Accepted Answer · 2011-07-28 13:33:01Z

1

Use " quotes. PHP doesn't substitute variables in a string enclosed in ' quotes.

answered Jul 28, 2011 at 13:33

Karoly Horvath

96.7k11 gold badges123 silver badges181 bronze badges

Collectives™ on Stack Overflow

Using PHP variables in document header

5 Answers 5

2 Comments

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

2 Comments

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related