Is there some way I can optimize this C# code?

Question

I have my code and I would like to optimize it. For me it looks like it's already optimized. Can anyone suggest how I could make it a bit more optimized?

if (target == "power")
{
    return new JsonResult { Data = new { RC = new Data.AdminPower(datastoreValue).Refresh() } };
} 
if (target == "notes")
{
    return new JsonResult { Data = new { RC = new Data.AdminNotes(datastoreValue).Refresh() } };
}
if (target == "book")
{
    return new JsonResult { Data = new { RC = new Data.AdminBook(datastoreValue).Refresh() } };
}
return null;

Since it already looks good enough to you, you can just move on in most cases. — BoltClock
– BoltClock, Commented Jul 28, 2011 at 0:01
Surely any performance you gain here would be fairly trivial? But if you really want to change something, I would agree with using switch. — user122211
– user122211, Commented Jul 28, 2011 at 0:04
Can you turn your target into an enumeration? Then you could have Target.Book, Target.Notes, etc. Then your comparing enumerated values, not literal strings. However, I don't see where target is being assigned, so that may not be an option. — George Johnston
– George Johnston, Commented Jul 28, 2011 at 0:13

Nick Rolando · Accepted Answer · 2011-07-28 00:10:20Z

2

switch statements are great for these situations:

switch(target)
{
case "power":
  return new JsonResult { Data = new { RC = new Data.AdminPower(datastoreValue).Refresh() } };
case "notes":
  return new JsonResult { Data = new { RC = new Data.AdminNotes(datastoreValue).Refresh() } };
case "book":
  return new JsonResult { Data = new { RC = new Data.AdminBook(datastoreValue).Refresh() } };
default:
  return null;
}

Dont really need the breaks tho, since it will be returning each time, but its good practice..

edited Jul 28, 2011 at 0:10

answered Jul 28, 2011 at 0:02

Nick Rolando

26.2k13 gold badges84 silver badges120 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

CodeNaked Over a year ago

See stackoverflow.com/questions/427760/…

George Johnston Over a year ago

@Nick You're going to get unreachable code warnings for the breaks;

Eric Over a year ago

I don't think the breaks are necessary.

Nick Rolando Over a year ago

I said the breaks weren't necessary, just said its good practice imo. OP can delete if she wants

CodeNaked · Accepted Answer · 2011-07-28 00:01:48Z

2

If you know that your method will be called more often with "book" values, then you should put that first. Basically sort by order of frequency.

answered Jul 28, 2011 at 0:01

CodeNaked

41.6k6 gold badges128 silver badges151 bronze badges

Comments

Eric · Accepted Answer · 2011-07-28 00:08:51Z

0

As someone else mentioned, you should put them in order of most likely to occur to minimize your total number of incorrect comparisons.

Maybe it's possible to change "power" "notes" and "book" to an enum or int representation, and that may be slightly faster than the string comparisons.

There's not a whole lot you can do that will result in any significant optimizations, though.

answered Jul 28, 2011 at 0:08

Eric

2,1284 gold badges30 silver badges45 bronze badges

Comments

Evan Mulawski · Accepted Answer · 2011-07-28 00:17:35Z

0

I don't know what's your idea about optimized, as a matter of speed, just put some 'else' before second and third 'if's but if you mean less code lines, then may be something like this could help you:

return 
((target == "power") ? new JsonResult { Data = new { RC = new Data.AdminPower(datastoreValue).Refresh() } } :
((target == "notes") ? new JsonResult { Data = new { RC = new Data.AdminNotes(datastoreValue).Refresh() } } : 
((target == "book") ? new JsonResult { Data = new { RC = new Data.AdminBook(datastoreValue).Refresh() } } : null))))

edited Jul 28, 2011 at 0:17

Evan Mulawski

55.5k16 gold badges122 silver badges147 bronze badges

answered Jul 28, 2011 at 0:06

Afshin

1,25412 silver badges29 bronze badges

2 Comments

Tim Over a year ago

My eyes would roll up into my head if I saw that line in code I had to maintain, and I'd probably mutter some very unnice things about the programmer's origin. Optimization is fine, but not to the point where readability goes out the window....

Evan Mulawski Over a year ago

While you're at it, remove all of the spaces and line breaks :). Nothing like reading a multiline ternary statement to wake you up in the morning.

Evan Mulawski · Accepted Answer · 2011-07-28 00:18:44Z

0

The only thing I would do is change the ifs to an if-elseif chain. There isn't really anything else you can do to improve performance.

edited Jul 28, 2011 at 0:18

answered Jul 28, 2011 at 0:01

Evan Mulawski

55.5k16 gold badges122 silver badges147 bronze badges

2 Comments

CodeNaked Over a year ago

The OP returns in the if-block, so else if won't help.

Evan Mulawski Over a year ago

@CodeNaked: I didn't say it would help. It is better communicated to anyone reading the code that the conditions are mutually exclusive.

Collectives™ on Stack Overflow

Is there some way I can optimize this C# code?

5 Answers 5

4 Comments

Comments

Comments

2 Comments

2 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

4 Comments

Comments

Comments

2 Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related