Can't Update database with Entity Framework Core

Question

I'm learning asp.net WebApi and EFCore (CodeFirst) and as an exercise, I'm building Warehouse Api and my update method doesn't work. This is my repository code:

public void Update(T toUpdate)
        {
            if(toUpdate == null) throw new ArgumentNullException("Entity is null");

            T tmp = GetById(toUpdate.Id);
            tmp = toUpdate;
            _context.SaveChanges();
        }

and this is my Service code:

public void UpdateEmployee(UpdateEmployeeCommand command)
        {
            UpdateEmployeeCommandValidator validator = new UpdateEmployeeCommandValidator();
            var results = validator.Validate(command);
            if (!results.IsValid)
            {
                throw new CommandValidationException(results.Errors.Select(x => new CommandValidationError
                {
                    ErrorCode = x.ErrorCode,
                    ErrorMessage = x.ErrorMessage,
                    PropertyName = x.PropertyName
                }));
            }
            _repository.Update(new Employee()
            {
                Id = command.Id,
                FirstName = command.FirstName,
                Address = command.Address,
                LastName = command.LastName,
                Age = command.Age,
                Email = command.Email,
                PhoneNumber = command.PhoneNumber
            });
        }

and this is how I use it in Controller:

public ActionResult UpdateEmployee(int Id, UpdateEmployeeCommand command)
        {
            if(Id != command.Id)
            {
                return BadRequest();
            }
            var employeeModelFromRepo = _repository.GetById(Id);
            if(employeeModelFromRepo == null)
            {
                return NotFound();
            }

            _employeeService.UpdateEmployee(command);

            return NoContent();
        }

When I call UpdateEmployee, it runs without any error but it doesn't update my database.

I'm new to this, so this might be an easy fix.

You need to copy new values to tmp, not just reassign the variable. — Guru Stron
– Guru Stron, Commented Jan 16, 2021 at 10:17
@GuruStron db.Update(toUpdate) gives me an error but db.Entry(tmp).CurrentValues.SetValues(toUpdate) work just fine. — Googli
– Googli, Commented Jan 16, 2021 at 10:48

Serge · Accepted Answer · 2021-01-16 14:23:47Z

1

I am using this generic update function:

public virtual T Update(T t) where T : class, IBaseEntity // contains Id as primary key
        {
            if (t == null)
                return null;
            var exist = Context.Set<T>().Find(t);

          // Or you can try 
           var exist = Context.Set<T>()
                    .Where(i=>i.Id=t.Id).FirstOrdDefault();

            if (exist == null) return exist;
            Context.Entry(exist).CurrentValues.SetValues(t);
            Context.SaveChanges();

            return exist;
        }

edited Jan 16, 2021 at 14:23

answered Jan 16, 2021 at 12:37

Serge

44.4k4 gold badges26 silver badges53 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

crucifery · Accepted Answer · 2021-01-16 10:15:10Z

0

Don't you forget to call your service method in the controller end-point? UpdateEmployee()

answered Jan 16, 2021 at 10:15

crucifery

4785 silver badges12 bronze badges

1 Comment

Googli Over a year ago

I've done that the first time I tried updating the database but it didn't work.

Googli · Accepted Answer · 2021-01-16 10:51:43Z

0

Commented solution works, i just had to add db.Entry(tmp).CurrentValues.SetValues(toUpdate) to the repository code.

answered Jan 16, 2021 at 10:51

Googli

157 bronze badges

Collectives™ on Stack Overflow

Can't Update database with Entity Framework Core

3 Answers 3

Comments

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related