React problem with array - component not loading?

Question

For some reason, my the boolean only returns the URL's the component is being ignored.. but I don't know why can someone help?

I want to return the Component inside the loop.. but nothing happens?

import React, { Component } from 'react';
import AwesomeSlider from 'react-awesome-slider';
import 'react-awesome-slider/dist/styles.css';
import 'bootstrap-4-grid/scss/grid.scss';

class Slider extends Component {

    render() {

        let showSlides = true;
        let images;

        if(showSlides) {
            images = [
                require('images/slider/1.jpg'),
                require('images/slider/2.jpg'),
                require('images/slider/3.jpg'),
                require('images/slider/4.jpg')
            ];

            <AwesomeSlider>
            {
                images.map(function(image){
                    return <div data-src={image} />
                })
            }
            </AwesomeSlider>
        }

        return (
            <div className="slider">
                <div className="container">
                    <div className="row">
                        <div className="col-lg-12">
                            {images}
                        </div>
                    </div>
                </div>
            </div>
        );
    }
}

export default Slider;

any error in console?

Suresh Prajapati
– Suresh Prajapati

2018-09-28 19:37:00 +00:00
Commented Sep 28, 2018 at 19:37 — Suresh Prajapati
– Suresh Prajapati, Commented Sep 28, 2018 at 19:37

rc_dz · Accepted Answer · 2018-09-28 19:42:11Z

2

You are not rendering the AwesomeSlider, it gets executed in your if statement, but never returned. you only return the array of images. you could do something like:

class Slider extends Component {

  render() {

    let showSlides = true;
    let images;

    if(showSlides) {
      images = [
        require('images/slider/1.jpg'),
        require('images/slider/2.jpg'),
        require('images/slider/3.jpg'),
        require('images/slider/4.jpg')
      ];
    }

    return (
      <div className="slider">
        <div className="container">
          <div className="row">
            <div className="col-lg-12">
              {
                (images && showSlides) &&
                <AwesomeSlider>
                  {
                    images.map(function(image){
                      return <div data-src={image} />
                    })
                  }
                </AwesomeSlider>
              }
            </div>
          </div>
        </div>
      </div>
    );
  }
}

export default Slider;

My react being a little rusty. take a look at React Conditional Rendering Also, having the images load inside the render function may not be the best idea, since they will be required every single time there is a change in the component, even if it has nothing to do with images.

answered Sep 28, 2018 at 19:42

rc_dz

4614 silver badges20 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

user10431099 Over a year ago

Thank you very much! What do you suggest for require instead i have tried using import for each image.. but can get pretty long. Thanks!

Collectives™ on Stack Overflow

React problem with array - component not loading?

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related