Copy multiple column values from SqlReader to array?

Question

How can I generate an array of string that will contain all the column info. this query will return a single row with multiple columns

var rowLines = new List<string>();

        try
        {
            using (SqlConnection connection = new SqlConnection(GetConnectionString()))
            {
                string query = "SELECT I1,I2,I3,I4,I5,I6,I7,I8,I9,I10,I11,I12,I13,I14,I15 FROM LABEL_OUT WHERE LABEL_NAME='" + labelName + "'";
                using (SqlCommand command = new SqlCommand(query, connection))
                {
                    connection.Open();

                    using (SqlDataReader reader = command.ExecuteReader())
                    {
                        while (reader.Read())
                        {
                            rowLines.Add(reader[0].ToString());
                        }

                    }
                }
            }

        }
        catch (Exception ex)
        {
            System.Windows.MessageBox.Show(ex.Message);
        }

here rowLines will Contain all the column value such as I1,I2,.....I15

You should also put your SqlConnection and your SqlCommand inside a using block to ensure correct resource release. — Uwe Keim
– Uwe Keim, Commented Sep 4, 2018 at 13:15
You're already adding the first column to your list. What is the issue? Add the other columns the same way. — user47589
– user47589, Commented Sep 4, 2018 at 13:16
@DreamTeK the number of times DataSet is a good solution to any problem is vanishingly small... — Marc Gravell
– Marc Gravell, Commented Sep 4, 2018 at 13:22

Marc Gravell · Accepted Answer · 2018-09-04 13:22:06Z

5

Probably the easiest way to do this is to use DbDataReader.GetValues(object[]), which populates a pre-existing array with the values from each column:

var vals = new object[reader.FieldCount];
while (reader.Read())
{
    reader.GetValues(vals);
    // ... do something with the values
}

answered Sep 4, 2018 at 13:22

Marc Gravell

1.1m273 gold badges2.6k silver badges3k bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Felipe Oriani · Accepted Answer · 2018-09-04 13:21:21Z

2

If you are sure that you will take a single line you could loop on the reader using the FieldCount and add each element on a List<string>. Finally, you could just return it as an array.

var rowLines = new List<string>();

if (reader.Read())
{
   for (int i = 0; i < reader.FieldCount; i++)
   {
      rowLines.Add(reader.IsDBNull(i) ? string.Empty : reader[i].ToString());
   }
}

return rowLines.ToArray();

answered Sep 4, 2018 at 13:21

Felipe Oriani

38.7k20 gold badges141 silver badges203 bronze badges

Collectives™ on Stack Overflow

Copy multiple column values from SqlReader to array?

2 Answers 2

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related