Why is my PHP upload script not working?

Question

I am doing some simple work with uploading a file. I am ignoring error checking and exceptions at this point just to get my uploads working. I have this HTML form:

<form action='addResult.php' method='post' enctype='multipart/form-data' target='results_iFrame' onsubmit='startUpload();'>
Entry: <input type='text' id='entry' />
Stop: <input type='text' id='stop' />
Final: <input type='text' id='final' />
Chart: <input type='file' id='chart' />
<input type='submit' value='Add' /></form>

As you can see, it calls 'addResult.php' within the iFrame 'results_iFrame'. The Javascript is just for animation purposes and to tell me when things are finished. addResult.php has this code in it (along with processing the other inputs):

$upload_dir = "../img/";
$chart_loc = $upload_dir.basename($_FILES['chart']['name']);

move_uploaded_file($_FILES['chart']['tmp_name'], $chart_loc);

print_r($_FILES);

It uses the 'chart' input from the form and tries to upload it. I have the print_r() function to display some information on $_FILES, but the array is empty, thus making this fail. What could I be doing wrong?

Blender · Accepted Answer · 2011-02-28 23:25:56Z

3

When dealing with forms, the name= is used to reference items serverside, not the id=.

Just change all those id attributes to namess, and you're good to go (hopefully).

edited Feb 28, 2011 at 23:25

answered Feb 28, 2011 at 23:19

Blender

300k55 gold badges462 silver badges511 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

ithcy Over a year ago

"Just change all those name attributes to ids" - other way around, surely? :)

Blender Over a year ago

Whoops, contradicting myself again ;)

Turner Over a year ago

Ah, of course - it's always something simple. I had converted this from sending information to a Javascript function that used the IDs and not Names. Thanks!

Blender Over a year ago

I've pulled clumps of hair so many times because of the name and id thing, so no worries.

ithcy Over a year ago

Same here. I still missed it in this question.

coreyward · Accepted Answer · 2011-02-28 23:19:24Z

1

You have to give your input elements name attributes or they don't get passed to your script. The id is used for DOM/browser/client-side use.

There might be another problem after you resolve this, but this is a good first step.

answered Feb 28, 2011 at 23:19

coreyward

80.5k21 gold badges148 silver badges176 bronze badges

Comments

icc · Accepted Answer · 2011-02-28 23:19:55Z

0

Try adding the name attribute to your input values like so:

<input type='file' id='chart' name="myfile"/>

answered Feb 28, 2011 at 23:19

icc

3011 silver badge5 bronze badges

Comments

Capsule · Accepted Answer · 2011-02-28 23:20:04Z

0

Your inputs have no "name" attribute, only IDs.

answered Feb 28, 2011 at 23:20

Capsule

6,1531 gold badge24 silver badges28 bronze badges

Comments

James Bell · Accepted Answer · 2011-02-28 23:21:28Z

0

You need to give your form fields name attributes

answered Feb 28, 2011 at 23:21

James Bell

6141 gold badge7 silver badges18 bronze badges

Collectives™ on Stack Overflow

Why is my PHP upload script not working?

5 Answers 5

5 Comments

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

5 Comments

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related