PHP File Upload Isn't Working

Question

So I built this simple script to upload files to an XAMPP server, and . . . it didn't work. When I ran it, it dies after the first if statement. EDIT: FIXED

Here's the FIXED html code:

<!DOCTYPE html>

<html>
<head>
<title>Awesome Life: File Upload</title>
<link rel="stylesheet" href="forms.css">
</head>
<body>
<div id="big_wrap">
    <section id="sign_up">
        <form action="http://localhost/mail.php" method="post" ENCTYPE="multipart/form-data">
            <span id="upText">File to Upload</span> 
            <br />
            <input style="margin-top:5px;" type="file" name="fileName">
            <br />
            <br />
            <input type="submit" id="button" name="submit" value="Upload">
        </form>
    </section>
</div>
</body>
</html>

And here's the FIXED script:

<?php
if(!isset($_FILES["fileName"])){
    die("It didn't work!");
}else{
    move_uploaded_file($_FILES["fileName"]["tmp_name"], "\xampp\htdocs\".$_FILES["fileName"]  ["name"]) or die("Didn't work");
}
?>

The file type isn't determined or tested, as I'm not going to be using this on the World Wide Web. I'm simply wondering why it doesn't work. Thanks!

EDIT: It was a simple matter of changing the edit permissions of the htdocs folder. I unchecked the read-only box and it worked fine. Thanks to all for contributing, and especially to Fred -ii-

We're gonna need to know more than just "It doesn't work tell me why". What is in your php.ini files regarding file uploads? How big is the file you're uploading and what MIME type does it have? (There is a default MB upload value that you may have to adjust) — Newbi3
– Newbi3, Commented Feb 27, 2014 at 16:18
These are the rules specified in the php.ini: file_uploads=On, upload_tmp_dir=C:\xampp\tmp, upload_max_filesize=2M, max_file_uploads=20, — crazyjedi98
– crazyjedi98, Commented Feb 27, 2014 at 16:20
Read the manual and make sure folders have write permissions. @crazyjedi98 and you probably need another \ in "\xampp\htdocs" as "\xampp\htdocs\" or may need to do "/xampp/htdocs/" — Funk Forty Niner
– Funk Forty Niner, Commented Feb 27, 2014 at 16:26
Fred -ii-, you are beast. All I had to do was remove the "read-only" permission from the htdocs folder and add another slash to the end. The other answers helped a lot, too. — crazyjedi98
– crazyjedi98, Commented Feb 27, 2014 at 16:36

Niet the Dark Absol · Accepted Answer · 2014-02-27 16:17:54Z

2

multipart/file-data is incorrect. It should be multipart/form-data instead.

Also, you should use move_uploaded_file to move the uploaded file somewhere. Not copy.

answered Feb 27, 2014 at 16:17

Niet the Dark Absol

326k86 gold badges480 silver badges604 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

crazyjedi98 Over a year ago

Changed the file-data to form-data and there's no difference. Also used the move_uploaded_file() and it didn't work, either. All I'm uploading for practice is a small .jpg file, 3.67 KB.

crazyjedi98 Over a year ago

HEY FOLKS IT WAS FRED -ii- THAT SOLVED A BIG HALF OF MA PROBLEM AS WELL! CHECK OUT HIS COMMENTS ON THE QUESTION!!!!

Girish · Accepted Answer · 2014-02-27 16:18:51Z

2

replace form attribute

ENCTYPE="multipart/file-data"

to

ENCTYPE="multipart/form-data"

answered Feb 27, 2014 at 16:18

Girish

12.1k3 gold badges37 silver badges54 bronze badges

Comments

Community · Accepted Answer · 2017-05-23 11:50:25Z

0

Turns out it was a mix of many things, but as OP stated: (and more importantly)

"Fred -ii-, you are beast. All I had to do was remove the "read-only" permission from the htdocs folder and add another slash to the end. The other answers helped a lot, too"

Answer transformed from my comment:

(Main problem) Make sure folders have write permissions. and you probably need another \ in "\xampp\htdocs" as "\xampp\htdocs\" or may need to do "/xampp/htdocs/"

edited May 23, 2017 at 11:50

CommunityBot

11 silver badge

answered Feb 27, 2014 at 16:39

Funk Forty Niner

74.2k14 gold badges71 silver badges146 bronze badges

Collectives™ on Stack Overflow

PHP File Upload Isn't Working

3 Answers 3

2 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

2 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related