Spring does not create ConstraintValidator

Question

Spring does not create an instance of class implementing ConstraintValidator. Even when I annotate RolesValidator with @Configuartion Spring create its instance, but validation doesn't work.

Here is my code:

@Constraint(validatedBy = [RolesValidator::class])
@Target(AnnotationTarget.PROPERTY, AnnotationTarget.FIELD)
@Retention(AnnotationRetention.RUNTIME)
annotation class ValidateRoles(
    val message: String = "{com.app.authservice.validators.ValidateRoles.message}",
    val groups: Array<KClass<*>> = arrayOf(),
    val payload: Array<KClass<out Payload>> = arrayOf()
)

//------Validator------

class RolesValidator : ConstraintValidator<ValidateRoles, Collection<String>> {
    lateinit var allowedValues: List<String>

    override fun initialize(constraintAnnotation: ValidateRoles?) {
        allowedValues = RoleType.values().map { it.name }
    }

    override fun isValid(value: Collection<String>?, context: ConstraintValidatorContext?): Boolean {
        return allowedValues.containsAll(value!!)
    }
}

//------Usage------

class AccountUpdateRolesDTO {
    @NotNull
    @ValidateRoles
    var roles: Set<String> = emptySet()
}

//------Controller------

@PreAuthorize("hasAnyAuthority($_ADMIN)")
@Transactional
@PutMapping("/{accountId}/roles")
fun updateRoles(
    @RequestBody @Valid body: AccountUpdateRolesDTO,
    @PathVariable accountId: Long,
    jwt: JWTData
): ResponseEntity<Void> {
    return ResponseEntity(HttpStatus.OK)
}

@edit https://github.com/spring-projects/spring-framework/issues/21242 (formerly SPR-16701)

Do you see any exceptions in log? How do you now that that's not created? — asm0dey
– asm0dey, Commented Apr 8, 2018 at 4:32
I setup a break point in the Validator and it's never invoked nor initialized. And no, no exceptions — Humberd
– Humberd, Commented Apr 8, 2018 at 8:56

Sébastien Deleuze · Accepted Answer · 2018-04-09 08:41:50Z

1

If you leverage annotation use-site targets, Kotlin tests pass as well:

class KotlinBodyDTO {
    @field:NotNull
    @field:ValidateRolesKotlin
    var roles: Set<String> = emptySet()
}

answered Apr 9, 2018 at 8:41

Sébastien Deleuze

6,2396 gold badges41 silver badges40 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Humberd · Accepted Answer · 2018-04-08 09:45:52Z

0

It seems that Spring doesn't recognize annotations in Kotlin. After I converted the annotation to Java everything was ok.

@Constraint(validatedBy = RolesValidator.class)
@Retention(RetentionPolicy.RUNTIME)
@Target({ElementType.FIELD})
public @interface ValidateRoles {
    String message() default "{com.app.authservice.validators.ValidateRoles.message}";

    Class[] groups() default {};

    Class[] payload() default {};
}

answered Apr 8, 2018 at 9:45

Humberd

2,9693 gold badges23 silver badges44 bronze badges

Collectives™ on Stack Overflow

Spring does not create ConstraintValidator

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related