jQuery DOM element creation

Question

I'm creating some elements using this code:

var itemButton = $('<button />',{'id': 'searchItemButtonId'+p[i].Id, 'class': 'itemButton', 'onclick':'javascript:alert();'}).append('Add');

The item is created with correct id and class set but the 'onclick' part doesn't work. Any ideea what is the problem here?

nickf · Accepted Answer · 2011-01-31 14:38:42Z

4

jQuery events drop the on prefix, plus you need to provide a function, not a string.

$("<button>", {
    click : function () {
        alert('something');
    }
});

answered Jan 31, 2011 at 14:38

nickf

548k199 gold badges660 silver badges727 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Andy · Accepted Answer · 2011-01-31 14:39:30Z

0

Why not use the jquery click method? So you don't need the onclick attribute

$('<button />',{'id': 'searchItemButtonId'+p[i].Id, 'class': 'itemButton'}).click( function(){ alert('asdf'); });

answered Jan 31, 2011 at 14:39

Andy

30.2k9 gold badges43 silver badges59 bronze badges

The example that happened to you "@Andy"works well, you can see here jsfiddle.net/hNdpp

Then maybe it something with my code as only the nickf way works for me.