Http service catch error angular js

Question

I have created a service that deal with get and post request in angularJS but the problem is in my controller I couldn't catch the error call back however success callback is working good:

app.js

 AuthenticationService.Login(function (_data) {
    $rootScope.showPreloader = false;
    console.log(_data)//works fine when call is succes


    },function (error){
      console.log(error)//not executed when error is thrown  
    });

authentication.service.js

 function Login(callback) {
        $http({
            method: "GET",
            url: "/auth/getRoles",
            headers: {
                "Accept-Language": "en-US, en;q=0.8",
                "Content-Type": "application/json;charset=UTF-8"
            }
        }).then(function (_response) {
            return _response.data;

            var serverData = response.data;

            callback(serverData);//getting respone is controller when succes    

        }, _handleError);
    };

 function _handleError(_error) {

        console.log(_error)//console prints on error
        return _error//controller never recevies the return statement
         };

the problem is in handleError function which never returns the error to controller any help will be greatly appreacited

Read blog.ninja-squad.com/2015/05/28/angularjs-promises.

JB Nizet
– JB Nizet

2017-12-17 12:40:10 +00:00
Commented Dec 17, 2017 at 12:40 — JB Nizet
– JB Nizet, Commented Dec 17, 2017 at 12:40

init fail · Accepted Answer · 2017-12-17 15:04:08Z

2

All you have to do is return the promise in your Login method

function Login(callback) {
    return $http(...success / error callback);
};

This way whichever method calls this is returned a promise that you can use ".then" on.

edit: It actually looks like you're really missing the point of promises here.

You define the method as above and then in some controller you can call on it as though it were a promise.

$scope.login = function() {

    LoginService.Login()
      .then(function(response){
        $scope.loginData = response
      }, function(err) {
      //Error handling...
      });

};

The benefit of this is that you can now do any kind of pre-processing necessary to manipulate the data in your LoginService and then you can just call is as a promise in any controller so long as you inject the login service.

answered Dec 17, 2017 at 15:04

init fail

3991 gold badge2 silver badges15 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Http service catch error angular js

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related