Retrieving number value from input instead of object

Question

I am trying to write a small program to determine the common factors between two numbers. I am having a problem getting the numbers, though. Here is my HTML code:

<p>Please input two numbers to find the common factors between them.</p>
 First number:<input type="number" id="firstNumber"></br>
 Second number:<input type="number" id="secondNumber"></br>
<button onclick="commonFactors(document.getElementById('firstNumber'), 
 document.getElementById('secondNumber'))">Submit</button>

However, instead of getting the numbers back, the console returns the following:

"<input type='number' id='firstNumber'>" "<input type='number' 
  id='secondNumber'>"

With the quotes. Can you tell me what I'm doing wrong?

Not sure it matters, but here's the JS:

function commonFactors(num1, num2) {
  console.log(num1, num2);
  var counter=Math.min(num1, num2);
  var factors=[];
  var k=0;  
  for (i=1; i<counter; i++) {
    if (num1%i==0) {
      if (num2%i==0) {
        factors[k]=i;
      }
    }
    k+=1;
  }
};

Laassari · Accepted Answer · 2017-10-17 15:57:03Z

2

because document.getElementById('firstNumber') is refering to the input, use +document.getElementById('firstNumber').value notice the + because the values you get from an input are of type string so we use the + to transform them to a number

Note: you can use a function instead of the + it's called parseInt() for integers and parseFloat() for float numbers

the result is

    <button onclick="commonFactors(parseInt(document.getElementById('firstNumber').value), 
 parseInt(document.getElementById('secondNumbe').value)">Submit</button>

edited Oct 17, 2017 at 15:57

answered Oct 17, 2017 at 13:54

Laassari

3264 silver badges17 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

apex2022 Over a year ago

Thanks to both of you! It took a combination of both parseInt and .value to work.

Laassari Over a year ago

yeah, you'll need both of them as stated in the first paragraph. I forgot to add .value in the example

R Bayo · Accepted Answer · 2017-10-17 13:53:17Z

1

You want to get the value of the input, not the input itself :

document.getElementById('firstNumber').value

answered Oct 17, 2017 at 13:53

R Bayo

691 silver badge9 bronze badges

1 Comment

apex2022 Over a year ago

Thanks! See above comment.

Collectives™ on Stack Overflow

Retrieving number value from input instead of object

2 Answers 2

2 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related