Python | simple if/else statement inside for loop - not working

Question

I've just started learning Python. After getting myself comfortable with Bash, I've decided to use Python and learn it. Please don't throw flame if this question seems stupid.

I got this "file.txt" which contains:

The if/else statement I'm using inside for loop does not seem to work:

with open('file.txt') as x:  
    for num in x:
        if num  >  90 :
            print "NOT ok - ",num
        else :
            print "Okay - ",num

I can't understand why the output would be "NOT ok" for all the numbers.

NOT ok -  81

NOT ok -  99

NOT ok -  90

NOT ok -  90

NOT ok -  70

NOT ok -  100

Any help would be appreciated. Thanks.

replace num with int(num) in if statement. You are comparing string with number. — Dinesh Pundkar
– Dinesh Pundkar, Commented Oct 5, 2017 at 3:51

Dinesh Pundkar · Accepted Answer · 2017-10-05 03:53:37Z

2

You are comparing string with number in if part.

Replace num with int(num) in if part.

>>> '81' > 90
True
>>> 81 > 90
False
>>>

answered Oct 5, 2017 at 3:53

Dinesh Pundkar

4,1962 gold badges26 silver badges38 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Kiran Cherian · Accepted Answer · 2017-10-05 03:56:15Z

0

As Dinesh pointed out, when reading from a file, the num is currently of string type. You can test the same by typing in the following:

for num in x:
    print type(num)   
    if num  >  90 :

So, before comparing the num, type it as below:

if int(num) > 90:

answered Oct 5, 2017 at 3:56

Kiran Cherian

531 silver badge10 bronze badges

Collectives™ on Stack Overflow

Python | simple if/else statement inside for loop - not working

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related