Cannot read property 'get' of undefined in Node.js

Question

I know some JS but I'm new to Node.js. I know this is a very common error but I couldn't find the source of the error since I lack debugging skills in Node.js. Here is my app.js :

var index = require('./routes/index');
var users = require('./routes/userlist');

var app = express();

// view engine setup
app.set('views', path.join(__dirname, 'views'));
app.set('view engine', 'jade');

// uncomment after placing your favicon in /public
//app.use(favicon(path.join(__dirname, 'public', 'favicon.ico')));
app.use(logger('dev'));
app.use(bodyParser.json());
app.use(bodyParser.urlencoded({ extended: false }));
app.use(cookieParser());
app.use(express.static(path.join(__dirname, 'public')));

app.use('/', index);
app.use('/userlist', users);

Here is my userlist.js :

var express = require('express');
var router = express.Router();

/* GET users listing. */
router.get('/', function(req, res, next) {
  res.send('respond with a resource');
});

module.exports = router;

Here is my index.js:

var express = require('express');
var router = express.Router();

router.get('/userlist', function(req, res) {
    var db = req.db;
    var collection = db.get('usercollection');
    console.log(collection);
    collection.find({},{},function(e,docs){
        res.render('userlist', {
            "userlist" : docs
        });
    });
});

Here is userlist view :

extends layout

block content
    h1.
        User List
    ul
        each user, i in userlist
            li
                a(href="mailto:#{user.email}")= user.username

I appreciate if you tell me where the problem is or tell me how I can detect the problem. Thanks in advance.

EDIT:

In console I get this :

GET /userlist 500 296.280 ms - 1501

EDIT 2: It gives me the error at this line :

var collection = db.get('usercollection');

EDIT 3: In index.js, I see that

router.get('/userlist', function(req, res) {
    var db = req.db;

req.db is undefined. Why is it undefined? Do you have any idea?

gte property of router in index.js is the problem ?

user6249539
– user6249539

2017-07-07 07:22:38 +00:00
Commented Jul 7, 2017 at 7:22 — user6249539
– user6249539, Commented Jul 7, 2017 at 7:22
Add var router = express.Router(); in index.js as well.

Fahad Nisar
– Fahad Nisar

2017-07-07 07:23:36 +00:00
Commented Jul 7, 2017 at 7:23 — Fahad Nisar
– Fahad Nisar, Commented Jul 7, 2017 at 7:23
@yashpandey it didn't work.

jason
– jason

2017-07-07 07:33:40 +00:00
Commented Jul 7, 2017 at 7:33 — jason
– jason, Commented Jul 7, 2017 at 7:33
@yashpandey I'm already having that line in index.js

jason
– jason

2017-07-07 07:39:19 +00:00
Commented Jul 7, 2017 at 7:39 — jason
– jason, Commented Jul 7, 2017 at 7:39

jason · Accepted Answer · 2017-07-07 08:47:39Z

3

Changing code to this worked:

app.use(function(req,res,next){
    req.db = db;
    next();
});
app.use('/', index);
app.use('/userlist', users);

answered Jul 7, 2017 at 8:47

jason

7,22439 gold badges125 silver badges211 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Shubham Verma · Accepted Answer · 2017-07-07 10:00:04Z

3

Change your code accordingly:

userlist.js

var express = require('express').Router();
var router = express.Router();

/* GET users listing. */
router.get('/', function(req, res, next) {
  res.send('respond with a resource');
});

module.exports = router;

index.js

var express = require('express').Router();
var router = express.Router();

router.get('/userlist', function(req, res) {
    var db = req.db;
    var collection = db.get('usercollection');
    console.log(collection);
    collection.find({},{},function(e,docs){
        res.render('userlist', {
            "userlist" : docs
        });
    });
});

You should use var router = require('express').Router(); instead of var router = require('express');

answered Jul 7, 2017 at 10:00

Shubham Verma

10.2k8 gold badges70 silver badges87 bronze badges

Collectives™ on Stack Overflow

Cannot read property 'get' of undefined in Node.js

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related