AngularJS service returning variable

Question

I have an angular 1.4 application where I have a service that encapsulates the communication with my backend. If I do something like following to return data from an endpoint. The Api service that I'm injecting encapsulates my $http ajax requests

function MyDataService(Api, $injector, $q, $log) {
    var self = this;
    function getAll(){
        return self.Api.get('/myData').then(function(data){
            self.data = data;
            return self.data;
        })
    }
    return self;
}

If I use this service method in a controller or other modules, Am I referencing directly that property? I mean, if I do a double binding in a controller and that variable change, self.data inside my service will change too? I think JS is using references by default.

Thank you very much

@ManikandanVelayutham that is wrapped in my other Api service — acostela
– acostela, Commented Apr 20, 2017 at 7:21

Tarek Salah uddin Mahmud · Accepted Answer · 2017-04-20 07:15:28Z

1

Yeah. you are referring the controller variable. use angular copy to avoid this. try this

function getAll(){
    return self.Api.get('/myData').then(function(data){
        self.data = data;
        var retdata={};
        angular.copy(data, retdata)
        return retdata;
    })
 }

answered Apr 20, 2017 at 7:15

Tarek Salah uddin Mahmud

9448 silver badges18 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

acostela Over a year ago

Or I can return data directly instead self.data. Am I wrong?

Collectives™ on Stack Overflow

AngularJS service returning variable

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related