AngularJS service to variable

Question

Is there a way to store data to a variable?

I tried:

$scope.another =
        function(){
            var new_data;
            userService.getInfo().success(function(data){
               new_data = data;
            });
            return new_data;
        };

var data = $scope.another();

but it returns 'undefined' in the console log. Thank you

EDIT

I now get an empty array for new_data .

var new_data = [];

$scope.another = 
                function(callback){
                    userService.getInfo().success(function(data){
                        paymentService.getCashierParams({ "cardNumber": data.cardNumber}).success(function(data){
                            gameService.getAllgames({ "PID":data.GetCashierParameters.PID, "limit": 6, "skinID": 1}).success(function(data) {
                                callback(data.data.GetFlashGamesResult.Data.FlashGame);
                            });
                        });
                    });
                };
          $scope.another(function(result){
                    new_data = result;
                });
                console.log(new_data);

The issue is that getInfo is asynchronus, this is a duplicate of How to return value from an asynchronous callback function?. — Kevin Brown-Silva
– Kevin Brown-Silva, Commented Dec 2, 2014 at 2:54
This is another asynchronous js question. Try throwing some console.log statements in and see what happens — Stephen
– Stephen, Commented Dec 2, 2014 at 2:54

Jackson Ray Hamilton · Accepted Answer · 2014-12-02 03:12:58Z

1

You need to think about this problem differently. Your getInfo method returns a promise. A promise's success callback is never immediately called. It may be called sometime in the future, but in the meantime your code will continue executing and the return value of $scope.another will be undefined.

Instead, place whatever logic you wish to execute within the success callback.

userService.getInfo().success(function (data) {
    // Do stuff with data.
});

If you are not used to working with asynchronous data, this may seem weird. But it is much better than the alternative, which is hanging the page for potentially many seconds while a network request, database read, etc, completes.

If you are worried about indentation, you can create separate function(s) to handle the data.

function processData(data) {
    // Process stuff...
    return data;
}

function handleData(data) {
    data = processData(data);
    console.log(data);
}

userService.getInfo().success(handleData);

edited Dec 2, 2014 at 3:12

answered Dec 2, 2014 at 3:00

Jackson Ray Hamilton

9,5766 gold badges54 silver badges81 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

sanosuke Over a year ago

I now get an empty array.

Jackson Ray Hamilton Over a year ago

In your latest edit, you are still not handling your logic in your callback. $scope.another(function (result) { console.log(result); }); would work. The callback passed to $scope.another is not going to execute before the console.log(new_data); executes. Also, you are "getting" an empty array because you set new_data to an empty array on line 1. You don't even need the new_data variable, just get rid of it.

sanosuke Over a year ago

What am I supposed to do so that console.log(new_data) executes after $scope.another? I noticed that console.log was executed before $scope.another.

Jackson Ray Hamilton Over a year ago

It's impossible. That's not how promises work. Do not try to solve the problem with sequential lines of code. Instead, solve the problem with a series of functions that pass data to each other.

geckob · Accepted Answer · 2014-12-02 16:29:07Z

0

This is due to the asynchronous function that you called. Try to use callback instead. Something like this:

$scope.another =
    function(fn){
        userService.getInfo().success(function(data){
           fn(data);
        });

    };


  var data = $scope.another(function(doSomething) {
    alert(doSomething);
    return doSomething;
};

edited Dec 2, 2014 at 16:29

answered Dec 2, 2014 at 3:38

geckob

8,2085 gold badges36 silver badges43 bronze badges

2 Comments

sanosuke Over a year ago

I don't know how but I still receive an undefined result.

geckob Over a year ago

@sanosuke: Where did you put the console.log? If you do it after $scope.another call, it makes sense. Because async will not wait but instead go to the next line. Try declare var data something else first then call $scope.another. If the data still have the old value, means the async call is not finish yet. Use promise

Collectives™ on Stack Overflow

AngularJS service to variable

2 Answers 2

4 Comments

2 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

4 Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related