Adding OnClick Event with Javascript is not working

Question

I'm trying to add an onclick event with JavaScript.

$.getJSON(api , function(data) {
    //First Option found (not working)
    //document.getElementById("today_button").SetAttrribute("onclick", "window.location.replace('" + data[1] + "')");

    //Second Option found (not working either)
    document.getElementById('today_button').onclick = "window.location.replace('" + data[1] + "');";
});

The Variables exist, the Event is fired, the data transmitted are correct and everything except this works just fine (like altering the disabled state of exactly this button).

I hope you can help me

Rob M. · Accepted Answer · 2017-03-21 19:40:00Z

3

You need to assign a function to onclick, not a string:

document.getElementById('today_button').onclick = function(event) {
   window.location.replace(data[1]);
}

answered Mar 21, 2017 at 19:40

Rob M.

36.6k6 gold badges56 silver badges51 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

daniel0mullins Over a year ago

This is the answer

Teemoh · Accepted Answer · 2017-03-21 19:41:22Z

0

Why are you assigning a string as a click handler? Just use a function.

document.getElementById('today_button').onclick = function () {
    location.replace(data[1]);
};

answered Mar 21, 2017 at 19:41

Teemoh

3522 silver badges12 bronze badges

Comments

tomaso · Accepted Answer · 2017-03-21 19:42:12Z

0

The problem is you assigned string to onclick, but it needs function.

document.getElementById('today_button').onclick = function() {
    window.location.replace(data[1]);
}

answered Mar 21, 2017 at 19:42

tomaso

979 bronze badges

Collectives™ on Stack Overflow

Adding OnClick Event with Javascript is not working

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related