JavaScript onclick event is not working

Question

A simple JavaScript onclick event is not working but I don't understand why, here is the code:

<button onclick="removeLol()">remove style</button>

function removeLol() {
    alert("hello");
}

and here is a simple example: http://jsfiddle.net/YNQg6/1/

Changing the fiddle to use "No wrap" fixes it. But that solution may not be what you need in the real page. — Barmar
– Barmar, Commented Mar 31, 2013 at 7:55
@funkybro No, that's not right. You need parentheses to call a function. — Barmar
– Barmar, Commented Mar 31, 2013 at 7:56

jantimon · Accepted Answer · 2013-03-31 08:06:17Z

4

That's only because of the way how jsfiddle inserts the javascript.

Jsfiddle wraps your code into a function which limits the scope and protects the global namespace:

window.onload=function(){
  function removeLol() {
    alert("hello");
    element.className = element.className.replace(" lol ", "");
  }
}

If you tell jsfiddle to inject the code into the document body it works:

Or you could turn your "local" function in a global one:

window.removeLol = removeLol;

answered Mar 31, 2013 at 7:57

jantimon

38.4k23 gold badges127 silver badges195 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Thanks, now I understand I haven't tested the code on localhost because I have been playing on jsFiddle.

What have you tried · Accepted Answer · 2013-03-31 07:58:42Z

0

The code works just fine (just tried it on my server). Check your console for other errors that may be causing the script to not run

answered Mar 31, 2013 at 7:58

11.2k4 gold badges35 silver badges45 bronze badges