149

I'm new to JavaScript. New as far as all I've really done with it is tweaked existing code and wrote small bits of jQuery.

Now I'm attempting to write a "class" with attributes and methods, but I'm having trouble with the methods. My code:

function Request(destination, stay_open) {
    this.state = "ready";
    this.xhr = null;
    this.destination = destination;
    this.stay_open = stay_open;

    this.open = function(data) {
        this.xhr = $.ajax({
            url: destination,
            success: this.handle_response,
            error: this.handle_failure,
            timeout: 100000000,
            data: data,
            dataType: 'json',
        });
    };

    /* snip... */

}

Request.prototype.start = function() {
    if( this.stay_open == true ) {
        this.open({msg: 'listen'});
    } else {

    }
};
//all console.log's omitted

The problem is, in Request.prototype.start, this is undefined and thus the if statement evaluates to false. What am I doing wrong here?

9
  • Is there a reason you have start in the prototype? Commented Oct 25, 2010 at 3:56
  • What's Request.prototype set to? Commented Oct 25, 2010 at 3:57
  • I had a similar question here: stackoverflow.com/questions/3198264/… in which there are a bunch of helpful links. The crux of it is that this in JavaScript is not a constant reference to the 'owner' of a prototypal function being called, like it would be in most OO languages like Java. Commented Oct 25, 2010 at 4:01
  • 1
    @Matt: Request is a constructor function. Request.prototype defaults to new Object(). Anything you add to it automatically becomes properties of objects created using new Request(). Commented Oct 25, 2010 at 4:02
  • 1
    I mean, that question was asked 3 years later than this one Commented May 8, 2019 at 9:58

9 Answers 9

211

I just wanted to point out that sometimes this error happens because a function has been passed as an argument to a high order function and then the scope of this got lost. In such cases, I would recommend passing such function bound to this. E.g.

this.myFunction.bind(this)

In addition, a lambda function works:

(args) => this.myFunction(args)
Sign up to request clarification or add additional context in comments.

11 Comments

Good explanation !! That was exactly what I was looking for.
there is no telling how much headache you just saved me
Why does the scope of this get lost?
Good question! I hope this helps: eliux.github.io/javascript/common-errors/…
Thanks. This is the correct anwer! Why isn't this accepted?
|
88

How are you calling the start function?

This should work (new is the key)

var o = new Request(destination, stay_open);
o.start();

If you directly call it like Request.prototype.start(), this will refer to the global context (window in browsers).

Also, if this is undefined, it results in an error. The if expression does not evaluate to false.

Update: this object is not set based on declaration, but by invocation. What it means is that if you assign the function property to a variable like x = o.start and call x(), this inside start no longer refers to o. This is what happens when you do setTimeout. To make it work, do this instead:

 var o = new Request(...);
 setTimeout(function() { o.start(); }, 1000);

4 Comments

I am using setTimeout: var listen = new Request(destination, stay_open); setTimeout(listen.start, 500);
This saved my life, upon trying to understand why the function I was passing to express' basicAuth was not working with the same output.
Or do o.start.bind(o). Why doesn't x = o.start; x() work?
.bind() returns a new function, not working in-place. So you'd have to do x = o.start.bind(o); x() or o.start = o.start.bind(o); x=o.start; x()
47

None of the previous answers had the full solution for me, so posting mine here.

I had a class, which was returning an error when I ran forEach on the method reference.

e.g.

class Foo {
  hello (name) {
    return `hello ${name}`
  }

  doGreet (name) {
    return console.log(this.hello(name)) // <- 'this' is undefined
  }
}

// print some names...
const foo = new Foo();
(['nick', 'john']).forEach(foo.doGreet)

// TypeError: Cannot read property 'hello' of undefined
//     at doGreet (/.../test.js:7:17)

The solution was to the bind the context of the method's this within a constructor. i.e.

class Foo {
  constructor () {
    this.doGreet = this.doGreet.bind(this) // <- Add this
  }

  hello (name) {
    return `hello ${name}`
  }

  doGreet (name) {
    return console.log(this.hello(name))
  }
}

10 Comments

PSA: I tried to do a bunch of shortcuts to automate this or make it less cumbersome. Unfortunately Object.keys(this) inside the constructor wasn't able to find all the keys on the object. The best I could do was this: const bind = (key) => { this[key] = this[key].bind(this) } Then call bind('hello'); bind('doGreet') for each method name manually :(
@DanielTonon See my answer :)
@WalterWoshid nice solution! Will give it a go.
You're a lifesaver, man javascript is stupid sometimes
How would you accomplish this if doGreet is a private method (#doGreet)? I get an error saying private methods are not writable.
|
18

JavaScript's OOP is a little funky (or a lot) and it takes some getting used to. This first thing you need to keep in mind is that there are no Classes and thinking in terms of classes can trip you up. And in order to use a method attached to a Constructor (the JavaScript equivalent of a Class definition) you need to instantiate your object. For example:

Ninja = function (name) {
    this.name = name;
};
aNinja = new Ninja('foxy');
aNinja.name; //-> 'foxy'

enemyNinja = new Ninja('boggis');
enemyNinja.name; //=> 'boggis'

Note that Ninja instances have the same properties but aNinja cannot access the properties of enemyNinja. (This part should be really easy/straightforward) Things get a bit different when you start adding stuff to the prototype:

Ninja.prototype.jump = function () {
   return this.name + ' jumped!';
};
Ninja.prototype.jump(); //-> Error.
aNinja.jump(); //-> 'foxy jumped!'
enemyNinja.jump(); //-> 'boggis jumped!'

Calling this directly will throw an error because this only points to the correct object (your "Class") when the Constructor is instantiated (otherwise it points to the global object, window in a browser)

Comments

10

Use arrow function:

Request.prototype.start = () => {
    if( this.stay_open == true ) {
        this.open({msg: 'listen'});
    } else {

    }
};

Comments

8

In ES2015 a.k.a ES6, class is a syntactic sugar for functions.

If you want to force to set a context for this you can use bind() method. As @chetan pointed, on invocation you can set the context as well! Check the example below:

class Form extends React.Component {
constructor() {
    super();
  }
  handleChange(e) {
    switch (e.target.id) {
      case 'owner':
        this.setState({owner: e.target.value});
        break;
      default:
    }
  }
  render() {
    return (
      <form onSubmit={this.handleNewCodeBlock}>
        <p>Owner:</p> <input onChange={this.handleChange.bind(this)} />
      </form>
    );
  }
}

Here we forced the context inside handleChange() to Form.

2 Comments

You should bind the function to this in the constructor. Otherwise you're binding it every time render is called instead of once when the class is instantiated. Also, most of your example is not really relevant to the question.
Or use the arrow syntax when defining the handleChange()
4

This question has been answered, but maybe this might someone else coming here.

I also had an issue where this is undefined, when I was foolishly trying to destructure the methods of a class when initialising it:

import MyClass from "./myClass"

// 'this' is not defined here:
const { aMethod } = new MyClass()
aMethod() // error: 'this' is not defined

// So instead, init as you would normally:
const myClass = new MyClass()
myClass.aMethod() // OK

Comments

4

If a function has been used as a high order function (passed as an argument) the scope of this gets lost.

To fix this problem one can bind this to the function like @Eliux described:

this.myFunction.bind(this);

To automate this process like @DanielTonon wanted you can do this in the constructor:

Object.getOwnPropertyNames(YourClass.prototype).forEach((key) => {
  if (key !== 'constructor') {
    this[key] = this[key].bind(this);
  }
});

2 Comments

Nice solution!!
Does this suffice? The autobind library uses more code (including Reflect). Link: stackoverflow.com/a/74369964/6702598
0

I was getting this error while passing a catch-handler for a promise.

class foo {

   catchHandler(error){
     // do something with this
   }
  
   async myFunction(){
       let x = await somePromise.catch(this.catchHandler);
   }
}

I was trying to bind the catchHandler-Function to this and i still got the error. What finally fixed it for me was not just pass the function as an argument but using a arrow-Function as a 'wrapper':

class foo {

   constructor(){
     this.catchHandler.bind(this); // <--
   }

   catchHandler(error){
     // do something with this
   }
  
   async myFunction(){
      --> let x = await somePromise.catch(e => this.catchHandler(e)); // <--
   }
}

This might not help OP but when you encounter the problem as stated in the Question-Header

Comments

Your Answer

By clicking “Post Your Answer”, you agree to our terms of service and acknowledge you have read our privacy policy.

Start asking to get answers

Find the answer to your question by asking.

Ask question

Explore related questions

See similar questions with these tags.