C# Simplifying string array initialization

Question

C# Simplifying string array initialization. Is there a way to optimize the below code in C#

string[] createdBy = new string[totalRowCount];
for (long i = 0; i < totalRowCount; i++)
{
    createdBy[i] = userName;
}

Also

int?[] defaultInd = new int?[totalRowCount];
        for (long i = 0; i < totalRowCount; i++)
        {
            if (i == 0)
            {
                defaultInd[i] = 1;
            }
            else
            {
                defaultInd[i] = 0;
            }
        }

Not trying to be a jerk, just want to offer some alternative advice since the answers below give you what you want. IMHO you should go for readability over clever syntactic sugar. I doubt there'll be a noticeable performance increase by using the shortened methods and you're just making things harder to debug if anything goes wrong here since I assume you're not overly familiar with the syntax. Just my two cents ;-) — Equalsk
– Equalsk, Commented Oct 18, 2016 at 16:24

Vivek Nuna · Accepted Answer · 2016-10-18 16:17:38Z

3

string[] myIntArray = Enumerable.Repeat(userName, totalRowCount).ToArray();

answered Oct 18, 2016 at 16:17

Vivek Nuna

30.6k34 gold badges162 silver badges259 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Sergey Kalinichenko · Accepted Answer · 2016-10-18 16:18:24Z

2

You can use Enumerable.Range to construct repeated sequences:

string[] createdBy = Enumerable.Range(0, totalRowCount)
    .Select(i => userName)
    .ToArray();
int?[] defaultInd = Enumerable.Range(0, totalRowCount)
    .Select(i => i==0 ? (int?)1 : 0)
    .ToArray();

Note how the first lambda expression does not use the value of index i, because all elements are set to the same string.

answered Oct 18, 2016 at 16:18

Sergey Kalinichenko

729k85 gold badges1.2k silver badges1.6k bronze badges

Comments

Olivier De Meulder · Accepted Answer · 2016-10-18 16:17:45Z

1

There are not many ways to simplify that for loop in both examples, unless you use Enumeration.Range, as shown in the other answers. However, in your second example, you could use the ternary operator:

defaultInd[i] = i == 0 ? 1 : 0;

answered Oct 18, 2016 at 16:17

Olivier De Meulder

2,5013 gold badges26 silver badges32 bronze badges

Collectives™ on Stack Overflow

C# Simplifying string array initialization

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related