Initialization of C# string array

Question

I want to declare a string array, I was using this way of doing it:

string[] matchingFiles = Directory.GetFiles(FilePath, FileNamePattern);

which worked perfectly.

Now I want to enclose the Directory.GetFiles call in a try/catch block, but I can't also have the declaration of the string array in there because then it won't be in the right scope to use it outside of the try block. But if I try this:

string[] matchingActiveLogFiles;
    try
    {
        matchingFiles = Directory.GetFiles(FilePath, FileNamePattern);
    }
    catch (Exception ex)
    {
        //log error
    }

I have not initialized the string array so I have an error. So I am wondering what is best practise in this situation, should I declare the string array outside the try block? And if so how?

Or just set it to null. The C# compiler wants you to initialize all variables before using them (unless passed as an out parameter). Initialization to null is sufficient in this case. — Dr. Andrew Burnett-Thompson
– Dr. Andrew Burnett-Thompson, Commented Jan 4, 2012 at 17:33
None of these are your issue. The issue is your naming. You're defining matchingActiveLogFiles but assigning to matchingFiles. .NET will automatically default your string array to null if you don't explicitly initialize it during definition. — Josh
– Josh, Commented Jan 4, 2012 at 17:35
@Josh but C# definite assigment rules require locals to be initialized. — phoog
– phoog, Commented Jan 4, 2012 at 18:09
@phoog, yeah I saw the mismatched names and forgot all about him needing to use it after the try/catch. My bad. — Josh
– Josh, Commented Jan 4, 2012 at 18:33

Ola Ström · Accepted Answer · 2024-03-14 09:28:05Z

4

The name is different for the string arrays, one is matchingActiveLogFiles the other is matchingFiles:

string[] matchingActiveLogFiles;
    try
    {
        matchingActiveLogFiles = Directory.GetFiles(FilePath, FileNamePattern);
    }
    catch (Exception ex)
    {
        //log error
    }

edited Mar 14, 2024 at 9:28

Ola Ström

5,4796 gold badges31 silver badges51 bronze badges

answered Jan 4, 2012 at 17:34

Gabe

50.6k29 gold badges147 silver badges182 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

LukeH Over a year ago

You're right, of course, but you still need to assign something to matchingActiveLogFiles -- either when you initialise it or in the catch block -- otherwise you'll get a "use of unassigned local variable" compile error when you try to use it.

phoog Over a year ago

@LukeH you don't need to assign anything to it if you never use it.

LukeH Over a year ago

@phoog: True, but the OP says that they want to "use it outside of the try block".

phoog Over a year ago

@LukeH Point taken. Since the code sample does't compile, it's probably not worth speculating too much about what the OP is trying to do.

Ola Ström · Accepted Answer · 2024-03-14 09:29:50Z

1

This will initialize your array:

string[] matchingActiveLogFiles = {};
    try
    {
        matchingFiles = Directory.GetFiles(FilePath, FileNamePattern);
    }
    catch (Exception ex)
    {
        //log error
    }

But I'm wondering, what error are you getting?

Even with an uninitialized array, the above code should work.

I also noticed that you have "matchingActiveLogFiles" on line 1 and "matchingFiles" on line 4. Perhaps that's your problem?

edited Mar 14, 2024 at 9:29

Ola Ström

5,4796 gold badges31 silver badges51 bronze badges

answered Jan 4, 2012 at 17:31

ristonj

1,6081 gold badge13 silver badges15 bronze badges

1 Comment

Robert Allan Hennigan Leahy Over a year ago

The C# compiler gets really angry when you do things like what he's demonstrated. I usually just assign whatever to null before the try block and the compiler seems okay with it.

Josh · Accepted Answer · 2012-01-04 17:32:47Z

0

The issue is your naming. You're defining matchingActiveLogFiles but assigning matchingFiles.

answered Jan 4, 2012 at 17:32

Josh

2,9751 gold badge21 silver badges29 bronze badges

Comments

Connell · Accepted Answer · 2012-01-04 17:36:14Z

0

You should declare the variable in the scope in which that variable is needed.

If you only need the variable in the try block, put it in there!
If you need it outside of the try block, what do you want the value to be if your code can't get the file contents? Set it to that on error.

answered Jan 4, 2012 at 17:36

Connell♦

14.4k11 gold badges62 silver badges98 bronze badges

Comments

MethodMan · Accepted Answer · 2012-01-04 17:39:57Z

0

you do not have to know the exact number of Items in order to initialize an array like

 string[] matchingActiveLogFiles = {}; 
this is what is called a dynamic array it's totally functional and I've had ZERO issues with declaring arrays this way.. 

List<string> matchingFiles= new List<string>();
try
 {
    matchingFiles.Add(Directory.GetFiles(FilePath, FileNamePattern));
    matchingActiveLogFiles = matchingFiles.ToArray(); 
 }
 catch (Exception ex)
 {
    //logerror
 }

answered Jan 4, 2012 at 17:39

MethodMan

18.9k6 gold badges41 silver badges53 bronze badges

Comments

Jeremy · Accepted Answer · 2012-07-27 16:15:05Z

0

Initialize it first:

 string[] matchingActiveLogFiles = new string[0];

edited Jul 27, 2012 at 16:15

Jeremy

9,0402 gold badges39 silver badges44 bronze badges

answered Jan 4, 2012 at 17:32

Aliostad

81.9k21 gold badges164 silver badges209 bronze badges

1 Comment

phoog Over a year ago

better to initialize to null; this way, you're creating a zero-length string array only to throw it away a moment later.

Rich O'Kelly · Accepted Answer · 2012-01-04 17:38:36Z

-1

Though I generally dislike methods with out params, this seems like a good candidate for a Try method:

bool TryGetMatchingLogFiles(out string[] matchingFiles )
{
  matchingFiles = null;
  try
  {
     matchingFiles = Directory.GetFiles(FilePath, FileNamePattern);
     return true;
  }
  catch (Exception ex)
  {
     //logerror
     return false;
  }
}

Usage:

string[] matchingActiveLogFiles;
if (TryGetMatchingLogFiles(out matchingActiveLogFiles))
{
  // Use matchingActiveLogFiles here
}

Or alternatively, just initialise your variable to null:

string[] matchingActiveLogFiles = null;
try ...

edited Jan 4, 2012 at 17:38

answered Jan 4, 2012 at 17:32

Rich O'Kelly

41.8k9 gold badges87 silver badges114 bronze badges

Collectives™ on Stack Overflow

Initialization of C# string array

7 Answers 7

4 Comments

1 Comment

Comments

Comments

Comments

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

7 Answers 7

4 Comments

1 Comment

Comments

Comments

Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related