Excel not Closing in vba access module

Question

What's wrong on the function below. Excel.exe*32 not closing in task manager.

Function formatExcel()
    Dim FileName As String
    FileName = "C:\This file\queryCentering.xlsx"
    Set xl = New Excel.Application
    Set wb = xl.Workbooks.Open(FileName)
    With wb.Sheets(1)
        Columns("E:E").Select
        Selection.NumberFormat = "m/d/yyyy"        

        Columns("C:C").HorizontalAlignment = xlCenter
        Rows("2:2").Select 
        Range(Selection, Selection.End(xlDown)).Select  
        Selection.RowHeight = 15 

    End With
    wb.Save
    wb.Close True
    Set wb = Nothing
    xl.Quit
    Set xl = Nothing
End Function

What are you doing with Selection.RowHeight = 15? Seems like the end result is to select some cells but what happens with that? — Brad
– Brad, Commented Sep 8, 2016 at 17:00

Andre · Accepted Answer · 2016-09-07 16:28:47Z

1

You have With wb.Sheets(1), but don't actually use it.

Also, it is advisable to not use the Selection object.

Try this (note the . before Columns)

With wb.Sheets(1)
    .Columns("E:E").NumberFormat = "m/d/yyyy"        
    .Columns("C:C").HorizontalAlignment = xlCenter
End With

answered Sep 7, 2016 at 16:28

Andre

27.7k7 gold badges43 silver badges85 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

pinkrose Over a year ago

Thanks- how do I translate this below into .row Rows("2:2").Select Range(Selection, Selection.End(xlDown)).Select Selection.RowHeight = 15

Andre Over a year ago

@pinkrose: Please don't post code in comments. Edit your question and add it there - but it seems like a new question, so perhaps post a new one.

ASH · Accepted Answer · 2016-09-15 03:04:36Z

0

YOU HAVE TO CLOSE EVERY SINGLE OBJECT THAT YOU OPEN. Andre underscored the issue. Look very closely at your code.

answered Sep 15, 2016 at 3:04

ASH

20.5k28 gold badges115 silver badges247 bronze badges

Collectives™ on Stack Overflow

Excel not Closing in vba access module

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related