Compile error when concatenating a string using Excel VBA

Question

I am trying to run this code:

Private Sub CommandButton1_Click()

Dim myFile As String, rng As Range, cellValue As Variant, i As Integer, j As Integer, cellValue1 As String

myFile = "c:\h\sales.TXT"
Set rng = Selection

Open myFile For Output As #1

For i = 1 To rng.Rows.Count
    cellValue1 = rng.Cells(i, 1).Value
    Write #1 "INSERT INTO JLPT COL1,COL2 VALUES ('" & cellValue1 & "')"
Next i

Close #1

End Sub

But it gives me a compile error with no more details on the line with Write.

Can someone give me some advice on this?

you are missing the comma after Write #1, modify to Write #1, "INSERT INTO JLPT COL1,COL2 VALUES ('" & cellValue1 & "')" — Shai Rado
– Shai Rado, Commented Aug 28, 2016 at 3:33
@ShaiRado - Can you add this as an answer so I can accept. Thank you — user1679941
– user1679941, Commented Aug 28, 2016 at 4:17

Shai Rado · Accepted Answer · 2016-08-28 05:00:56Z

1

you are missing a comma, replace your line :

Write #1 "INSERT INTO JLPT COL1,COL2 VALUES ('" & cellValue1 & "')"

With:

Write #1, "INSERT INTO JLPT COL1,COL2 VALUES ('" & cellValue1 & "')"

answered Aug 28, 2016 at 5:00

Shai Rado

33.7k7 gold badges32 silver badges55 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Compile error when concatenating a string using Excel VBA

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related