for loop with if statement - array without comma

Question

This is my part of code:

for( $i = $aKeys['iStart']; $i < $aKeys['iEnd']; $i++ )
{
        $aData = $this->aProducts[$aProducts[$i]];

        $content .= '"'.$aData['sName'].'"';

        if ($i < $aKeys['iEnd'])  
        {
           $content .= ', '; 
        } 
        $i2++;
}

Full code gives me this as result:

["word1", "word2", "word3", ]

This is a simple array, which I will use, but this won't work because after word3 there is a comma sign. How to write this if statement to get result like: ["word1", "word2", "word3"] ?

you can use array_push(); to eliminate the comma thingy :) — Matt Magallo
– Matt Magallo, Commented Mar 30, 2016 at 9:18
instead of appending to $content you can create array like $content = [] and use array_push($aData['sName'] and to get result like ["word1","word2","word3"] simply use json_encode($content); — Akshay Khale
– Akshay Khale, Commented Mar 30, 2016 at 9:20

Kevin Grosgojat · Accepted Answer · 2016-03-30 09:15:36Z

5

Put a condition on the length-1 to fix your bug.

for( $i = $aKeys['iStart']; $i < $aKeys['iEnd']; $i++ ){
        $aData = $this->aProducts[$aProducts[$i]];

        $content .= '"'.$aData['sName'].'"';

        if ($i < $aKeys['iEnd']-1) {
        $content .= ', '; 
        } 
        $i2++;
      }

answered Mar 30, 2016 at 9:15

Kevin Grosgojat

1,3799 silver badges13 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

user3180931 Over a year ago

This is it! Thank you!

Sougata Bose · Accepted Answer · 2016-03-30 09:16:49Z

1

Alternatively you can use an array for this. And at the end simply implode them.

for( $i = $aKeys['iStart']; $i < $aKeys['iEnd']; $i++ ){
    $aData = $this->aProducts[$aProducts[$i]];
    $content[] = '"'.$aData['sName'].'"';
}

$content = '"' . implode('","', $content) . '"';

answered Mar 30, 2016 at 9:16

Sougata Bose

31.8k8 gold badges52 silver badges89 bronze badges

Comments

Ravindra Bhalothia · Accepted Answer · 2016-03-30 09:19:20Z

1

You can use rtrim() to remove comma.

rtrim($content, ',');

As I can see you want all names as comma separated. Than you can do like that as well :

$content = array();
for( $i = $aKeys['iStart']; $i < $aKeys['iEnd']; $i++ ){
    $aData = $this->aProducts[$aProducts[$i]];
    $content[] = $aData['sName'];
}

echo implode(',',$content);

edited Mar 30, 2016 at 9:19

answered Mar 30, 2016 at 9:13

Ravindra Bhalothia

1,7802 gold badges13 silver badges16 bronze badges

2 Comments

Jamie Harding Over a year ago

please add more detail and maybe a link to the actual function page : php.net/manual/en/function.ltrim.php

Ravindra Bhalothia Over a year ago

Oops sorry we need to use rtrim. Thanks @Sougata

Ojetunde John · Accepted Answer · 2016-03-30 09:22:43Z

1

for( $i = $aKeys['iStart']; $i < $aKeys['iEnd']; $i++ ){
        $aData = $this->aProducts[$aProducts[$i]];

        $content .= '"'.$aData['sName'].'"';

        if ($i < $aKeys['iEnd'] && $i!=($aKeys['iEnd']-1)) { //this condition also considers $i not to be the last element of the array before appending the comma to it.
        $content .= ', '; 
        } 
        $i2++;
      }

answered Mar 30, 2016 at 9:22

Ojetunde John

624 bronze badges

Comments

Magicprog.fr · Accepted Answer · 2016-03-30 09:54:52Z

0

Use array_push(); function

$var = array();

loop(condition){
    array_push($var, $value);
}

edited Mar 30, 2016 at 9:54

Magicprog.fr

4,1204 gold badges29 silver badges35 bronze badges

answered Mar 30, 2016 at 9:17

Matt Magallo

3261 silver badge20 bronze badges

3 Comments

Sougata Bose Over a year ago

OP wants a string with , separated values not an array.

Akshay Khale Over a year ago

@Sougata You should use Matt's solution and to get comma separated result you can use json_encode($array)

Matt Magallo Over a year ago

@akshaykhale, Yes maybe but OP wants manual , separation. It's okay ^_^

Collectives™ on Stack Overflow

for loop with if statement - array without comma

5 Answers 5

1 Comment

Comments

2 Comments

Comments

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

1 Comment

Comments

2 Comments

Comments

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related