Json String Syntax in C# [duplicate]

Question

I just have a quick question. I have this JSON string in C#, and I'm wondering if it's correct.

 var json_data1 = "{\"serverName\": \"" + ServerStats.serverName +
               "\",\"cpuLoad\":\" " + ServerStats.cpuLoad +
               "\",\"memLoad\":\" " + ServerStats.memoryLoad +
               "\",\"drive0\":\" " + ServerStats.drive0 +
               "\",\"drive1\":\" " + ServerStats.drive1 +
               "\",\"drive2\":\" " + ServerStats.drive2 +
               "\",\"drive3\":\" " + ServerStats.drive3 +
               "\",\"drive4\":\" " + ServerStats.drive4 +
               "\",\"service0\":\" " + ServerStats.testService0 +
               "\",\"service1\":\" " + ServerStats.testService1 +
               "\",\"service2\":\" " + ServerStats.testService2 +
               "\",\"lastBoot\":\" " + ServerStats.lastBoot + "\"}";

Is there anything wrong syntax wise with my JSON string? The reason I'm asking is that the JSON string posts to my API if I take out ",lastBoot:" + ServerStats.lastBoot, but when that line is added into the JSON string, it does not work. Any ideas? Thank you for your help.

EDIT: I updated my JSON string above, will this one work?

Yes, you need quotes around everything. You'd be better off using a serialiser, like newtonsoft, to do this work for you rather than manually constructing strings. For validating things, get the contents of json_data1, and stick it in jsonlint.com — James Thorpe
– James Thorpe, Commented Feb 5, 2016 at 10:25
Is it a possibility for you to use a Json parser like Json.Net: newtonsoft.com/json ? — Thomas
– Thomas, Commented Feb 5, 2016 at 10:28

Community · Accepted Answer · 2017-05-23 12:23:48Z

0

If your intent on building this your self and not using a parser then this should do it:

Stringbuilder sb = new StringBuilder();
sb.Append("{");
sb.AppendFormat("serverName:'{0}',", ServerStats.serverName);
...etc
sb.Append("}");
var json_data1 = sb.ToString();

your json should be in the format

{serverName:'myserverName', cpuLoad:'myCpuLoad',....}

You can validate you Json using JsonLint

edited May 23, 2017 at 12:23

CommunityBot

11 silver badge

answered Feb 5, 2016 at 10:38

Liam

30k28 gold badges143 silver badges206 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Json String Syntax in C# [duplicate]

1 Answer 1

Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Linked

Related