How to bind Spring form:checkbox instead of form:checkboxes?

Question

I am having problems with form:checkbox. I cannot make it display selected values. When I selected values and submit, correct values are display in database. When I load page all values (checkboxes) are not selected.

Elements below are located inside this:

<form:form role="form" commandName="user" class="form-horizontal" action="${form_url}">
</form:form>

This works just fine:

<form:checkboxes items="${availableRoles}" path="roles" itemLabel="role" itemValue="id" element="div class='checkbox'"/>

This doesn't work:

<c:forEach items="${availableRoles}" var="r" varStatus="status">
    <div class="checkbox">
        <form:checkbox path="roles" label="${r.description}" value="${r.id}"/>
    </div>
</c:forEach>

This is my domain class:

public class User {
    private List<Role> roles;

    public List<Role> getRoles() {
        return roles;
    }

    public void setRoles(List<Role> roles) {
        this.roles = roles;
    }

This is my custom property editor:

public class RolePropertyEditor extends PropertyEditorSupport {

    @Override
    public void setAsText(String text) {
        Role role = new Role();
        role.setId(Integer.valueOf(text));
        setValue(role);
    }

}

Controller has this method:

@InitBinder
public void initBinder(WebDataBinder binder) {
    binder.registerCustomEditor(Role.class, new RolePropertyEditor());
}

Controller method:

@RequestMapping(value = "/update/{userId}", method = RequestMethod.GET)
public String updateUser(@PathVariable Integer userId, Model model) {
    User user = userService.getByUserId(userId);
    List<Role> availableRoles = roleService.getAllRoles();

    model.addAttribute("availableRoles", availableRoles);
    model.addAttribute("user", user);

    return "user/update";
}

fritz · Accepted Answer · 2015-10-07 11:04:56Z

1

After debugging session I found the solution.

Because of Spring internals JSP should look like this:

<c:forEach items="${availableRoles}" var="r">
    <div class="checkbox">                          
        <form:checkbox path="roles" label="${r.description}" value="${r}"  />
    </div>
</c:forEach>

Notice that value is item (r), not item's member like r.id.

Also you need getAsText implementation in your custom PropertyEditor.

@Override
public String getAsText() {
    Role role = (Role) this.getValue();
    return role.getId().toString();
}

answered Oct 7, 2015 at 11:04

fritz

1111 silver badge11 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

How to bind Spring form:checkbox instead of form:checkboxes?

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related