Python scripting error

Question

I am trying to start solr through python script. There are three conditions:

1st when user doesnot provide port number and zookeeper instance.

command : /home/user/solr-5.3.0/bin/solr start

This one works.

2nd when user provides only port number.

command : /home/user/solr-5.3.0/bin/solr start -p 8898

This does not executes.

ERROR: Port number is required when using the -p option!

3rd when user provides both port number and zookeeper instance.

command :/home/user/solr-5.3.0/bin/solr start -p 8898 -z localhost:2181

This also does not executes.

ERROR: Port number is required when using the -p option!

I am new to python scripting. I just need to write scripts for deploying it on servers. Is this the right way of doing it ? Are there any better ways to do it ?

Code

#!/usr/bin/env python


import os
import optparse
import subprocess


parser = optparse.OptionParser()
parser.add_option('-p', dest='port', help='Port(By Default it will start at 8983)',type=int)
parser.add_option('-z', dest='zk', help='zookeeper Server(By default it will take embedded zookeeper)')



(options, args) = parser.parse_args()


if options.port is None and options.zk is None:
subprocess.call(["/home/user/solr-5.3.0/bin/solr start"], shell=True)
elif options.zk is None:
subprocess.call(["/home/user/solr-5.3.0/bin/solr start -p ", str(options.port)], shell=True)
else :
subprocess.call(["/home/user/solr-5.3.0/bin/solr start -p", str(options.port), "-z", str(options.zk)], shell=True)

When you specify shell=True, you should just pass an entire string to subprocess rather than a list. See answers like this one for more explanation. — wkl
– wkl, Commented Sep 22, 2015 at 13:06

sisoft · Accepted Answer · 2015-09-22 13:05:19Z

1

Corrected code:

if options.port is None and options.zk is None:
    subprocess.call(["/home/user/solr-5.3.0/bin/solr", "start"])
elif options.zk is None:
    subprocess.call(["/home/user/solr-5.3.0/bin/solr", "start", "-p", str(options.port)])
else:
    subprocess.call(["/home/user/solr-5.3.0/bin/solr", "start", "-p", str(options.port), "-z", str(options.zk)])

edited Sep 22, 2015 at 13:05

answered Sep 22, 2015 at 12:55

sisoft

97310 silver badges22 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

wkl Over a year ago

shell=True is mentioned multiple times in the subprocess documentation (or python3's doc if you prefer).

Ritesh Sinha Over a year ago

ERROR: -p 8898 is not supported by this script

sisoft Over a year ago

@user-4870385, you can try to separate keys and arguments: subprocess.call(["/home/user/solr-5.3.0/bin/solr", "start", "-p", str(options.port)])

Collectives™ on Stack Overflow

Python scripting error

1 Answer 1

3 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related