validating a string using try except in python

Question

I've been trying to get this piece of code to work:

    last_bits_repeat= "yes"
    while last_bits_repeat== "yes":
        try:
            another_number_repeat= input("do you have another number to add??")
            another_number_repeat= str(another_number_repeat)
        except TypeError as e:
            if not repeat:
                print("You left this empty, please write something!")   
                last_bits_repeat= "yes"
            else:
                print("This is not empty, but invalid")

It doesn't work and I think its because of TypeError.

My question is which exception should I use to validate the string? The user should input either "yes" or "no".

At the very least, this code contains incorrect indentation. — d33tah
– d33tah, Commented Jul 12, 2015 at 15:53
Why do you think an exception would be raised at all? When you run this without the try/except, do you see one? Which? — Daniel Roseman
– Daniel Roseman, Commented Jul 12, 2015 at 15:58

miraculixx · Accepted Answer · 2015-07-12 16:20:35Z

1

It doesn't work and I think its because of TypeError.

If this is python2 (with from __future__ import print_function), it doesn't work because input doesn't do what you expect it to - namely it doesn't assign the value entered to the another_number_repeat variable Use raw_input instead.

In python3, input is just fine, but it doesn't raise an exception.

My question is which exception should I use to validate the string? (another_number_repeat) if I can at all.

You don't need an exception. Try this:

def get_choice(prompt, choices):
    valid = False
    while not valid:
        answer = raw_input(prompt).strip()
        valid = answer in choices
    return answer

answer = get_choice('do you have another number to add?', ['yes', 'no'])

I've used this code for a integer earlier on so I think it should work with the correct exception.

If you want to use the same code for arbitrary input (numbers, text, choices), a regular expression helps to avoid cumbersome exception checking, and keeps the code slick:

import re
def get_input(prompt, regexp, convert=str):
    valid = False
    while not valid:
        answer = raw_input(prompt).strip()
        valid = re.match(regexp, answer)
    return convert(answer)

get_input('add a number? (yes or no)', r'(yes)|(no)')
get_input('number?', r'^[0-9]*$', int)

edited Jul 12, 2015 at 16:20

answered Jul 12, 2015 at 16:02

miraculixx

10.4k2 gold badges43 silver badges63 bronze badges

Sign up to request clarification or add additional context in comments.

6 Comments

NightShadeQueen Over a year ago

It's python3 - note the print() - so input is correct

miraculixx Over a year ago

@NightShadeQueen if this was python3, why use something like str(another_number_repeat)?

NightShadeQueen Over a year ago

Because he or she is confused. On the other hand, he or she isn't getting a syntax error, which means the print() is likely correct.

Anand S Kumar Over a year ago

You would not get syntax error for print("You left this empty, please write something!") in Python 2 either. Though I am guessing you are correct, the code maybe python 3.

gbdcal1 Over a year ago

Its python 3, I used str(another_number_repeat) simply because my previous validation (which was validating a integer) didn't work when I did new_number= int(input("give me a number") but did when I did new_number= input("Give me a number") then new_number= int(new_number). Sorry for the confusion!

|

Fragtzack · Accepted Answer · 2015-07-12 16:33:46Z

0

What I normally do in these Exception "figure out" issues:

Remove the whole try: except: clause
Run the script and produce the invalid data
Watch the error message which will print the Exception name If you expect multiple error type, run the test case for each test case: --blank entry (where user hits ) --User enters an Octal code, etc
Recreate the try: except: ,specifying the Exception name(s) from step #3

Example code to figure out the Exception code :

    last_bits_repeat= "yes"
    while last_bits_repeat== "yes":

            another_number_repeat= input("do you have another number to add??")
            another_number_repeat= str(another_number_repeat)

answered Jul 12, 2015 at 16:33

Fragtzack

3731 gold badge5 silver badges13 bronze badges

Collectives™ on Stack Overflow

validating a string using try except in python

2 Answers 2

6 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

6 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related