Asp MVC Dropdown List Selected Value not selected

Question

I have the following dropdown list but the selected value doesn't seem to working. It defaults to first item in list.

    private List<string> GetTransmissions()
    {
        List<string> Transmission = new List<string>();
        Transmission.Add("Automatic");
        Transmission.Add("Manual");


        return Transmission;
    }

     Car car = _repository.GetCarDetails(id);

     ViewBag.Transmission = new SelectList(GetTransmissions(), car.Transmission);

In my view I have:

    @Html.DropDownList("Transmission", (IEnumerable<SelectListItem>)ViewBag.Transmission, "Please Select", new { @class = "form-control" })

What is car.Transmission referring to? Is it a class of some sort or a string? — Brad C
– Brad C, Commented Jul 8, 2015 at 14:21
Car is a class which has an attribute called Transmission of type string — adam78
– adam78, Commented Jul 8, 2015 at 14:24
Use a view model instead of using viewbag if you can, much better practice. — Inspector Squirrel
– Inspector Squirrel, Commented Jul 8, 2015 at 14:39

DaniCE · Accepted Answer · 2015-07-08 14:40:11Z

2

You need to differentiate the property that holds the list and the property that holds the selected value.

I recommend using a viewmodel for the view like this:

public class CarViewModel
{

    public SelectList Transmissions
    {
        get
        {
            return new SelectList(new List<SelectListItem>{
                new SelectListItem {  Value = "Manual"},
                new SelectListItem {  Value = "Automatic"}
            });                
        }
    }

    public string Transmission { get; set; }

}

and use this DropDownListFor version

 @Html.DropDownListFor(model => model.Transmission,
    @Model.Transmissions, "Please Select", new { @class = "form-control" })

answered Jul 8, 2015 at 14:40

DaniCE

2,4211 gold badge20 silver badges28 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

hutchonoid · Accepted Answer · 2015-07-08 14:42:26Z

If you are restricted to using ViewBag rather than a View Model and an @Html.DropDownList Html Helper then I would do the following:

        ViewBag.Transmissions = new SelectList(GetTransmissions()
        .Select(t => new {value = t, text = t}), 
            "value", "text");
        ViewBag.Transmission = car.Transmission;

The above creates the SelectList, then projects so that your dropdown renders text and values. This is saved in the ViewBag.Transmissions, which is the available options.

Then set your selected transmission with ViewBag.Transmission.

Your razor code would also need to be changed to use ViewBag.Transmissions too:

@Html.DropDownList("Transmission", 
      (IEnumerable<SelectListItem>)ViewBag.Transmissions, 
         "Please Select", new { @class = "form-control" })

Working Fiddle

adam78 · Accepted Answer · 2015-07-09 07:54:34Z

-1

Managed to fix by changing

 ViewBag.Transmission = new SelectList(GetTransmissions(), car.Transmission);

To

 ViewBag.Transmissions = new SelectList(GetTransmissions(), car.Transmission);

The Car model already contains an attribute called Transmission so need need for another ViewBag to hold this attribute.

In the my razor code use the following instead

  @Html.DropDownList("Transmission", (IEnumerable<SelectListItem>)ViewBag.Transmissions, "Please Select", new { @class = "form-control" })

answered Jul 9, 2015 at 7:54

adam78

10.2k24 gold badges111 silver badges223 bronze badges

Collectives™ on Stack Overflow

Asp MVC Dropdown List Selected Value not selected

3 Answers 3

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related