Laravel 5 upload multiple image validation

Question

I am trying to upload multiple images at once. The files are being uploaded but they pass the validation even if they are not a valid iamge. I want to upload all valid files and return a message with the ammount of files that werent uploaded succesful.

My function:

public function addImages($id, Request$request)
{
    $files = Input::file('images');
    $uploaded = 0;
    $failed = 0;
    foreach ($files as $file) {

        // Validate each file
        $rules = array('file' => 'required|image');
        $validator = Validator::make(array('file'=> $file), $rules);

        if($validator->passes()) {
            $destinationPath = 'uploads';
            $filename = $file->getClientOriginalName();
            $upload_success = $file->move($destinationPath, $filename);
            if($upload_success){
                $uploaded ++;
            }
            else {
               $failed ++;
            }
        } else {
            $failed ++;
        }
    }
    \Session::flash('success_message',$uploaded.' files uploaded.');
    if($failed > 0){
        \Session::flash('errors','Some files werent valid.');
    }
    return redirect('admin/myroute/'.$id);
}

For some reason if I upload files withhout any extension they are still uploaded. What am I doing wrong?

Mete Kabak · Accepted Answer · 2015-06-28 01:04:09Z

2

You should not validate it in controller, You should use each method for it, example in Your Request file.

protected function getValidatorInstance()
{
    $validator = parent::getValidatorInstance();


    $validator->each('files', ['image']);

    return $validator;
}

This simply checks all the files.

more information,

Laravel API about validation

edited Jun 28, 2015 at 1:04

answered Jun 28, 2015 at 0:58

Mete Kabak

3323 silver badges19 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

ujwal dhakal · Accepted Answer · 2015-06-28 14:02:41Z

-1

if your taking about validation you should specify like file types you can specify the the name and make a validation like this 'image' => 'mimes:jpeg,jpg,bmp,png' . Hope this would help

answered Jun 28, 2015 at 14:02

ujwal dhakal

2,4893 gold badges33 silver badges53 bronze badges

4 Comments

ujwal dhakal Over a year ago

image is the input field name and mimes is the validation

Mete Kabak Over a year ago

image is also a validation rule, and it uses mimes:jpeg,jpg,png,bmp by default.

ujwal dhakal Over a year ago

i know but in the code given by me image means the input name :) and giving the mimes validation :) may be we both are misunderstanding nm :)

Mete Kabak Over a year ago

I know, the problem is you don't need to use mimes instead of image that asked on the question.

Collectives™ on Stack Overflow

Laravel 5 upload multiple image validation

2 Answers 2

Comments

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related