get data from database and display it in gridview (asp.net)

Question

I have a database (SQL server) and I added it into my webpage project but the problem is I cannot display the data in a gridview.

Here is my code:

string query;
SqlCommand SqlCommand;
SqlDataReader reader;
int sindex=DropDownList1.SelectedIndex+1;
int hindex =DropDownList3.SelectedIndex+1;
SqlDataAdapter adapter = new SqlDataAdapter();
//Open the connection to db
conn.Open();                
query = string.Format("select * from table where clumn='"+s+"' ", s);
SqlCommand = new SqlCommand(query, conn);
adapter.SelectCommand = new SqlCommand(query, conn);              
reader = SqlCommand.ExecuteReader();               
GridView2.DataSource = reader;
GridView2.DataBind();

Enrique Zavaleta · Accepted Answer · 2015-05-04 13:38:34Z

4

Change this

query = string.Format("select * from table where clumn='"+s+"' ", s);

to this

query = string.Format("select * from table where clumn='{0}' ", s);

answered May 4, 2015 at 13:38

Enrique Zavaleta

2,1083 gold badges23 silver badges31 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

User1000547 Over a year ago

Actually, just use parameters.

zed · Accepted Answer · 2015-05-04 14:03:59Z

Use SqlParameters instead of manipulating a string as you are doing now.
Also, use using statement to dispose objects correctly.
Don't use select * because it will affect performance, only select the columns needed.
Here an example of your code, modified:

using (SqlConnection conn = new SqlConnection(yourConnectionString))
{
    SqlCommand command = new SqlCommand();
    command.Connection = conn;
    command.CommandType = CommandType.Text;
    command.CommandText = "select column, column2 from table where column=@column";

    command.Parameters.Add(new SqlParameter("column", SqlDbType.VarChar, 50));
    command.Parameters["column"].Value = yourColumnValue;

    conn.Open();

    using (SqlDataReader sdr = sco.ExecuteReader())
    {
        GridView2.DataSource = sdr;
        GridView2.DataBind();
    }
}

apomene · Accepted Answer · 2015-05-04 13:41:40Z

0

better use SqlDatadapter:

  DataTable dt = new DataTable();
 ...
using (SqlDataAdapter a = new SqlDataAdapter( new SqlCommand(query, conn)))
                  {
                      GridView2.DataSource =a.Fill(dt).AsDataView();
                  }

answered May 4, 2015 at 13:41

apomene

14.4k10 gold badges51 silver badges76 bronze badges

Collectives™ on Stack Overflow

get data from database and display it in gridview (asp.net)

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related