Python error in If-Then statement

Question

I am writing a program in python, which works like this:

Take input string through Serial port, when press enter (Carriage Return)
Check $ sign on the first character of input string then continue if present
Remove all the unwanted character and alphabetics except numerics and , and then print it.

Problem

Program stuck, if $ sign is not present in input string because next time if It get input string with $, it doesn't print the values

kindly review my codes below and guide me on how do I resolve it?

CODE

import serial,re

x = [0,0,0]
ser = serial.Serial('/dev/ttyAMA0', 9600)
buffer = ''

while True:
    buffer += ser.read(ser.inWaiting())
    if '\n' in buffer:
        if buffer[0] == '$':
            x= re.sub("[^0-9\,]","", buffer)
            x1 = x.rstrip()
            x2= x1.split(",")
            print((x2[0]),(x2[1]),(x2[2]))            
            buffer = ""

Each time through the loop you add to the end of the buffer. This doesn't change the beginning of the buffer. So if it didn't start with $ the first time, it never will. — Barmar
– Barmar, Commented Apr 22, 2015 at 21:26
It's not clear from your description what you're supposed to do if it doesn't start with $. Maybe you should break out of the loop? — Barmar
– Barmar, Commented Apr 22, 2015 at 21:27

enigma · Accepted Answer · 2015-04-22 21:28:36Z

2

Although it's not exactly obvious what the end intent of your code is, you might just need to unindent the last line to clear the buffer every time, otherwise you are constantly adding to it, and if it doesn't start with a $, it never will.

while True:
    buffer += ser.read(ser.inWaiting())
    if '\n' in buffer:
        if buffer[0] == '$':
            x= re.sub("[^0-9\,]","", buffer)
            x1 = x.rstrip()
            x2= x1.split(",")
            print((x2[0]),(x2[1]),(x2[2]))            
        buffer = ""

answered Apr 22, 2015 at 21:28

enigma

3,5012 gold badges19 silver badges31 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Community · Accepted Answer · 2017-05-23 10:24:05Z

2

The problem is that you keep adding the new lines onto the end of the buffer, only clearing it out if you happen to have a command. So, once you get a line that isn't a command, your buffer will never start with a command.

I think enigma's answer is what you were asking for.

But it's still not going to work right if you can ever get two lines (or, worse, part of one line and part of the next) in the same buffer. So, you really want something more like this:

while True:
    buffer += ser.read(ser.inWaiting())
    lines = buffer.split('\n')
    for line in lines[:-1]:
        if line[0] == '$':
            x= re.sub("[^0-9\,]","", line)
            x1 = x.rstrip()
            x2= x1.split(",")
            print((x2[0]),(x2[1]),(x2[2]))            
    buffer = lines[-1]

The split will break the buffer into all of the complete lines, plus either an empty string or a leftover partial line. So, you process the complete lines, and stick the leftover empty string or partial line into the buffer to be added to on the next read.

edited May 23, 2017 at 10:24

CommunityBot

11 silver badge

answered Apr 22, 2015 at 22:09

abarnert

368k54 gold badges626 silver badges691 bronze badges

1 Comment

enigma Over a year ago

Ah yes, much more robust than my quick fix, nice

Collectives™ on Stack Overflow

Python error in If-Then statement

2 Answers 2

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related