JSON access variable field

Question

I'm trying to write a library for Riot (League of legends API) in NodeJS and I have the following problem.

I'm doing:

function getSummonerProfile(sum) {
    var summoner = sum.replace(/\s+/g, '');

    request("https://na.api.pvp.net/api/lol/na/v1.4/summoner/by-name/"
            + summoner + "?api_key=" + api_key, function(error, response, body) {
        console.log(body);
    });
}

getSummonerProfile("some player");

the console shows:

{
    "player": {
        "id": 37842773,
        "name": "player",
        "profileIconId": 548,
        "summonerLevel": 30,
        "revisionDate": 1368783726000
    }
}

Now "player" is a variable (function parameter); how can I access the data? to get for example, only the id.

body.summonner and body["player"] throw undefined.

EDIT 1 (complete code):

var request = require("request");
var api_key = 'example';

function getSummonerProfile(sum) {
    var summoner = sum.replace(/\s+/g, '');

    request("https://na.api.pvp.net/api/lol/na/v1.4/summoner/by-name/"
            + summoner + "?api_key=" + api_key, function(error, response, body) {
        console.log(body.summoner.id);
    });
}

getSummonerProfile("some player");

In that case you're doing something wrong. Show exactly what you're doing. — Etheryte
– Etheryte, Commented Dec 22, 2014 at 2:21
Unrelated to the question, but just a pointer: you should use encodeURIComponent on the summoner variable and api key as you insert them into the API URL. — Joel Cox
– Joel Cox, Commented Dec 22, 2014 at 2:23

user3117575 · Accepted Answer · 2014-12-22 02:27:14Z

3

Are you actually getting a JavaScript Object? You're probably getting a JSON string, you need to parse it back into a JavaScript Object...

var newdata = JSON.parse(body);
console.log(newdata.player.id);

Support is no worry, according to caniuse.com

answered Dec 22, 2014 at 2:27

user3117575

Sign up to request clarification or add additional context in comments.

Comments

Lajos Veres · Accepted Answer · 2014-12-22 02:45:02Z

1

Your function getSummonerProfile only sends a request, using this request function which seems to be processing the internal part (console.log) when the request return with the data from server side. So basically you should save the data instead of the console.log line. You could bind it somewhere or save to a variable. And it seems that player is the body variable's key you are looking for.

Maybe something like this:

var request = require("request");
var api_key = 'example';
var summoners = {};

function getSummonerProfile(sum) {
    var summoner = sum.replace(/\s+/g, '');

    request("https://na.api.pvp.net/api/lol/na/v1.4/summoner/by-name/" + summoner + "?api_key=" + api_key, function(error, response, body) {
        summoners[summoner]=JSON.parse(body);
        console.log(summoners[summoner].player.id);
    });
}

getSummonerProfile("some player");

edited Dec 22, 2014 at 2:45

answered Dec 22, 2014 at 2:27

Lajos Veres

13.7k7 gold badges47 silver badges57 bronze badges

7 Comments

mdv Over a year ago

but console.log(summoner[summoner].id); gots me undefined :(

Lajos Veres Over a year ago

and console.log(summoner[summoner]?

Lajos Veres Over a year ago

if it displays the structure than yoiu0 should use this way the body: summoner[summoner]=JSON.parse(body.player);

Lajos Veres Over a year ago

if you use this way: summoner[summoner]=JSON.parse(body); console.log(summoner[summoner].player.id;?

mdv Over a year ago

summoner[summoner]=JSON.parse(body); console.log(summoner[summoner].summoner.id); TypeError: Cannot read property 'summoner' of undefined

|

aleberguer · Accepted Answer · 2014-12-22 02:23:37Z

1

if you have a variable like this

json_var = {
    "player": {
        "id": 37842773,
        "name": "player",
        "profileIconId": 548,
        "summonerLevel": 30,
        "revisionDate": 1368783726000
    }
}

you can do this to access the data

id = json_var["player"]["id"]

edited Dec 22, 2014 at 2:23

answered Dec 22, 2014 at 2:22

aleberguer

3706 silver badges15 bronze badges

1 Comment

Sean Whelan Over a year ago

Thank you! I've been looking forever for a solution to this, I don't know how I didn't think of that!

Community · Accepted Answer · 2017-05-23 10:33:39Z

0

What you are trying to do is JSON deserialization.

If you are using javascript, your question has an answer here: deserialize from json to javascript object

If you are using another language, the principle is the same, you need to have a class that matches the fields of your JSON file and use a deserializer.

edited May 23, 2017 at 10:33

CommunityBot

11 silver badge

answered Dec 22, 2014 at 2:23

TNTanuki

597 bronze badges

1 Comment

mdv Over a year ago

The response returns JSON object. developer.riotgames.com/docs/getting-started

Johan Karlsson · Accepted Answer · 2014-12-22 02:49:53Z

0

You are getting the response as a jsonstring. To get response as js object try this:

request({url: "https://na.api.pvp.net/api/lol/na/v1.4/summoner/by-name/" + summoner + "?api_key=" + api_key, json: true}, function(error, response, body) {
        console.log(body.player.id);
    });
}

answered Dec 22, 2014 at 2:49

Johan Karlsson

6,4761 gold badge22 silver badges28 bronze badges

Collectives™ on Stack Overflow

JSON access variable field

5 Answers 5

Comments

7 Comments

1 Comment

1 Comment

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

7 Comments

1 Comment

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related