Task.Run inner code not executing

Question

I'm writing a server-client and want to run operation using Task.Run(() => {SomeCode}); this Is my code

Task.Run(() =>
{
_control_com_peer2peer.VerifyConnection(port: 6001, IpAddressClient: ComboBoxRemoteIP.Text);
});

the inner code is basically

public void VerifyConnection(int port, string IpAddressClient)
{
Control_PeerSessionListCheckCreate(RemoteIP: IpAddressClient);
Domain_Peer2PeerCom.peerSessionList.Find(x => x.remoteIP == IpAddressClient).CommandLocker("Hello");
Domain_Peer2PeerCom.PeerSessionChangeIsConnected(IpAddressClient, true);             
}

I've break points inside VerifyConnection and none of them fire .

EDIT

entire code for the button firing the Task

private void Connect_Click(object sender, EventArgs e)
{
    string s_RemoteIP;



    if (ComboBoxRemoteIP.Text != "")
    {
        if (Network.startPing(ComboBoxRemoteIP.Text))
        {
            Control_Peer2peerCom.Control_PeerSessionListCheckCreate(ComboBoxRemoteIP.Text);
            //bool IspeerReal = Control_Peer2peerCom.peerSessionListGet(ComboBoxRemoteIP.Text, out peerSessionCurrentParam);
            if (/*IspeerReal&&*/!(Control_Peer2peerCom.Control_PeerSessionCheckIsConnected(ComboBoxRemoteIP.Text)))//peerSessionCurrentParam.IsConnetcted))//(!Peer2peerCom.isPeerConnetionVerifaied)
            {
                SelectiveEnable();
                tbStatus.Text = "Wait...";
                tbStatus.BackColor = Color.Yellow;
                s_RemoteIP = ComboBoxRemoteIP.Text;
                Task.Run(() =>
                {
                 _control_com_peer2peer.VerifyConnection(port: 6001, IpAddressClient: 
                 ComboBoxRemoteIP.Text);
                });
             //more code here , Not related
             }

of course if I run the method out side of the Task.Run it runs fine

what can be the cause of it

@KarolMarianSłuszniak: Such an advise is useless without any explanation or example how to do it then. — Patrick Hofman
– Patrick Hofman, Commented Jul 8, 2014 at 7:52
@LordTitiKaka: Try to add a try ... catch inside the Task.Run and check if there is an error. — Patrick Hofman
– Patrick Hofman, Commented Jul 8, 2014 at 7:53
@PatrickHofman did that and yet nothing happens , Should I add more code ? — LordTitiKaka
– LordTitiKaka, Commented Jul 8, 2014 at 7:57
Did you write the error message to Console or MessageBox? — Patrick Hofman
– Patrick Hofman, Commented Jul 8, 2014 at 7:59

LordTitiKaka · Accepted Answer · 2014-07-08 08:59:01Z

1

the problem was in the task.run of course , once I changed to simple thread exception thrown for cross thread ! my mistake was sending ComboBoxRemoteIP.Text to task

the task didnt trow any exception so I want able to catch the problem

the way I've cerrected it was just adding

String Ipddress = ComboBoxRemoteIP.Text

and sending the string instead

answered Jul 8, 2014 at 8:59

LordTitiKaka

2,1562 gold badges34 silver badges52 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

AK_ Over a year ago

the problem is not with task.run, the problem was you used Taks for a procedural action and didn't check for errors...

LordTitiKaka Over a year ago

@AK_ can you explain how I correctly collect errors from Task ?? I've scatters those bloody monsters all over my code ... :)

AK_ Over a year ago

msdn.microsoft.com/en-us/library/dd997415(v=vs.110).aspx and msdn.microsoft.com/en-us/library/dd537614(v=vs.110).aspx There are also some good blog posts about this around the internet... In general Tasks are OK for functions that return something, but you should be very careful and think through every possible scenario when your'e using tasks for procedural stuff

AK_ Over a year ago

or just use a better programming language like F# : tomasp.net/blog/csharp-async-gotchas.aspx the link also has a lot C# async pitfalls...

AK_ Over a year ago

also read this: blog.stephencleary.com/2012/07/dont-block-on-async-code.html

Collectives™ on Stack Overflow

Task.Run inner code not executing

1 Answer 1

5 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

5 Comments

Your Answer

Sign up or log in

Post as a guest

Related