php noob-file upload script problems

Question

I have this script and when i try to run it, it just says waiting for localhost and never actually runs. If i go to my localhost i can run other files with no problem.

What's wrong with this script?

<?php 
    $dir = 'Images/uploaded/';
    if($handle = opendir($dir)) {
        $file = readdir($handle);

        while($file !== false) {
            echo "<li><img class=\"thumb\" src=\"".$dir.$file."\" /></li>";
        }
    }

    closedir($handle);
?>

Dolph · Accepted Answer · 2010-02-25 01:34:23Z

3

You're not modifying $file inside the loop. $file never changes, and therefore you have an infinite loop.

From http://php.net/readdir:

/* This is the correct way to loop over the directory. */
while (false !== ($file = readdir($handle))) {
    echo "$file\n";
}

answered Feb 25, 2010 at 1:34

Dolph

50.9k13 gold badges66 silver badges92 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Ignacio Vazquez-Abrams · Accepted Answer · 2010-02-25 01:33:24Z

1

You need to call readdir() within the loop.

answered Feb 25, 2010 at 1:33

Ignacio Vazquez-Abrams

804k160 gold badges1.4k silver badges1.4k bronze badges

Collectives™ on Stack Overflow

php noob-file upload script problems

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related