Error with executable after compiling

Question

Could you please help me with pinning a problem down in my code?

The program is supposed to ask for the user to enter dog names and finally print the name of the third dog. When Icompile and execute the program, it says that "it stopped working" and windows asks me if I wanna close the program or do something else.

#include<iostream>
#include<cstdlib>
using namespace std;

main()
{
    string perros[10];
    int i;
    for(i=1; i<11; i++)
    {   
        cout<<"Introduce el nombre del perro"<<endl<<i;
        cin>>perros[i];

    }

    cout<<"El nombre del tercer perro es "<<perros[2];
    system("pause");
}

HadeS · Accepted Answer · 2014-02-25 03:04:17Z

1

You should start start loop from 0 to 9

for(i=0; i<10; i++)

Hope this will remove error...

answered Feb 25, 2014 at 3:04

HadeS

2,03820 silver badges38 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Mike Seymour · Accepted Answer · 2014-02-25 03:03:29Z

1

Array indexes start at zero; so your loop should be

for(i=0; i<10; i++)

Yours tries to write into the 11th element of a 10-element array, corrupting memory and unleashing untold mayhem.

answered Feb 25, 2014 at 3:03

Mike Seymour

256k30 gold badges467 silver badges658 bronze badges

Comments

László Papp · Accepted Answer · 2014-02-25 03:35:36Z

0

You need to start the indexing from zero, not one because that is how C/C++ arrays are indexed. You will overflow the maximum size of the stack object.

So, you would be writing something like this after fixing this issue in your original code:

#include<iostream>
#include<cstdlib>
using namespace std;

main()
{
    string perros[10];
    int i;
    for(i=0; i<10; i++)
    {   
        cout<<"Introduce el nombre del perro"<<endl<<i;
        cin>>perros[i];

    }

    cout<<"El nombre del tercer perro es "<<perros[2];
    system("pause");
}

Note that, you also do not use the for loop as it was intended to be used. You can merge the int i; line into the for loop.

However, a more intelligent and C++'ish solution would be to use a standard algorithm for this, and not very low-level indexing, exactly to avoid such issues.

So, you would be writing something like this:

#include<iostream>
#include<cstdlib>
#include <algorithm>
using namespace std;

void readNextString(string str)
{
    cout<<"Introduce el nombre del perro"<<endl;
    cin >> str;
}

main()
{
    string perros[10];
    for_each(perros, perros + 10, readNextString);
    cout<<"El nombre del tercer perro es "<<perros[2];
    system("pause");
}

answered Feb 25, 2014 at 3:35

László Papp

53.5k40 gold badges118 silver badges142 bronze badges

2 Comments

Paco Meraz Over a year ago

thanks bro, i dont know a lot of commands yet cos im a 1st grade student haha but yeah i corrected the code and it worked really good, thanks to all

László Papp Over a year ago

@PacoMeraz: just use the second snippet that I pasted. Do not use low-level indexing, when you actually wish to go through each element without the actual need for the index. If you happen to use C++11, you could even eliminate the readNextString function in favor of lambda.

Collectives™ on Stack Overflow

Error with executable after compiling

3 Answers 3

Comments

Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related