Function in a Function Errors

Question

function Sign1(){
    $check = array(
        '23-03-2014' => 'saturday 22 may',
        '17-05-2014' => 'friday 16 may'
    );
    Dateoption();
}
function Sign2(){
    $check = array(
        '10-02-2014' => 'monday 10 feb',
        '15-02-2014' => 'friday 15 feb',
        '14-03-2014' => 'friday 14 march'
    );
    Dateoption();
}
function Dateoption(){
    $now = time();
    $result = array();
    foreach($check as $date => $text) {
        if($now  <= strtotime($date)) {
            $result[] = $text;
        }
    }
    $html = '';
    foreach($result as $v) {
        $html .= '<option>'.$v.'</option>';
    }
    return $html;
}
$Content= '
<div class="content">
    I am signing up for the following date:<br />
    <select name="date[0]">
        '. Sign1() .'
    </select>
    <select>
        '. Sign2() .'
    </select>
</div>
';
echo $Content;

Why is this not working? It is going wrong @ foreach($check as $date => $text) { but what do i have to change to let this work. I'm doing this So i only have to type the function once instead of copy pasting it everywhere.

You start with "And again", which is a strange way to start a question. Also, what is it supposed to do, what does it actually do, and why do the dates in Sign1 have no relationship to their descriptions? — Mr Lister
– Mr Lister, Commented Feb 11, 2014 at 10:30
Please add tags to your question. Especially about the language involved. — arkascha
– arkascha, Commented Feb 11, 2014 at 10:34

Andrew Mackrodt · Accepted Answer · 2014-02-11 10:58:05Z

1

This is to do with variable scope. Dateoption cannot see the $check variable. The php documentation describes this as: However, within user-defined functions a local function scope is introduced. Any variable used inside a function is by default limited to the local function scope.

You need to pass $check as a parameter to the Dateoption method.

function Sign1(){
    $check = array(
        '23-03-2014' => 'saturday 22 may',
        '17-05-2014' => 'friday 16 may'
    );
    return Dateoption($check);
}
function Sign2(){
    $check = array(
        '10-02-2014' => 'monday 10 feb',
        '15-02-2014' => 'friday 15 feb',
        '14-03-2014' => 'friday 14 march'
    );
    return Dateoption($check);
}
function Dateoption($check){
    $now = time();
    $result = array();
    foreach($check as $date => $text) {
        if($now  <= strtotime($date)) {
            $result[] = $text;
        }
    }
    $html = '';
    foreach($result as $v) {
        $html .= '<option>'.$v.'</option>';
    }
    return $html;
}
$Content= '
<div class="content">
    I am signing up for the following date:<br />
    <select name="date[0]">
        '. Sign1() .'
    </select>
    <select>
        '. Sign2() .'
    </select>
</div>
';
echo $Content;

edited Feb 11, 2014 at 10:58

answered Feb 11, 2014 at 10:49

Andrew Mackrodt

1,82614 silver badges10 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Harryaars Over a year ago

Yeah we are in the right way now, but there is nothing showing up in the select sections? Do you know anything about that?

Andrew Mackrodt Over a year ago

Sign1 and Sign2 also need to return the output of Dateoption. I have updated my answer.

Harryaars Over a year ago

Aaaahhh like that! Thnxs man! This helps me a lot! (Yeah i know i'm sometimes a little bit noobisch but thats why i ask and i learn a lot about it!)

Collectives™ on Stack Overflow

Function in a Function Errors

1 Answer 1

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related