URL Encode string for Href ASP.NET MVC / Razor

Question

I'm trying to build an Href using Razor The string is going to end up looking like this:

https://www.notmysite/controller/action?order_ID=xxxxxxx&hashComparator=iFxp3%2BszAMaEB%2FnHCtRr9Ulhv0DumtyDumCik4gKypJqi0BdOGXXsr9QDkfefAsLaR1Xy%2BrX9VcuzP1pF2k6dL%2F92UxphzTKqNAZP2SSZGWtvyO5az%2F9JvDY%2Bsq5TBQo7%2FYAAMIU4QxiSX1SBKk8SUNECW3ZmKM%3D

In my model I have the order id and the hash string As the route is not a part of my site I don't believe I can use the default methods like @Url.Action and therefore can't use protocol: Request.Url.Scheme like I've used elsewhere.

So at present I'm trying to figure out how to create this using string functions I've tried Url.Encode Url.EscapeDataString Html.Encode but am getting no where fast:

<a href="@Uri.EscapeDataString("https://www.notmysite.co.uk/controller/action?order_ID=" + Model.bookingNumber + "&hashComparator=" + Model.hashCode)">Click Here to be transferred</a>

The output text always has plusses and equals in them and doesn't work. Which combination do I need?!

Feanaro · Accepted Answer · 2016-04-26 10:26:59Z

49

I've figured out a way of doing it:

@{
  var url = string.Format(
      "https://www.notmysite.co.uk/controller/action?order_ID={0}&hashComparator={1}",
      @Uri.EscapeDataString(Model.bookingNumber.ToString()),
      @Uri.EscapeDataString(Model.hashCode));
}
 <p><a href="@url">Click Here to be transferred</a></p>

Edit 2015 - As mentioned by Jerads post - The solution is to only encode the query string elements and not the whole URL - which is what the above does.

edited Apr 26, 2016 at 10:26

Feanaro

9323 gold badges20 silver badges35 bronze badges

answered Jan 16, 2014 at 11:24

Chris Nevill

6,19011 gold badges48 silver badges83 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Deathstalker · Accepted Answer · 2018-05-07 17:06:41Z

5

This was the first link that came up for this issue for me. The answers didn't work for me though because I am using core, I think. So wanted to add this in.

System.Net.WebUtility.UrlEncode(MyVariableName)

If Url.Encode doesn't work try the above. Also as stated before don't use this on the entire URL string, just use it for the individual querystring variables. Otherwise there is a good chance your URL wont work.

answered May 7, 2018 at 17:06

Deathstalker

1,0101 gold badge13 silver badges10 bronze badges

Comments

Jerad Rose · Accepted Answer · 2015-10-21 17:44:09Z

4

The problem is that you're trying to encode the whole URL. The only pieces you want to encode are the querystring values, and you can just use Url.Encode() for this.

You don't want to encode the address, the querystring params, or the ? and & delimiters, otherwise you'll end up with an address the browser can't parse.

Ultimately, it would look something like this:

<a href="https://www.notmysite.co.uk/controller/[email protected](Model.bookingNumber)&[email protected](Model.hashCode)">Click Here to be transferred</a>

answered Oct 21, 2015 at 17:44

Jerad Rose

15.5k18 gold badges88 silver badges157 bronze badges

5 Comments

Chris Nevill Over a year ago

I'm not really sure that your answer adds anything over mine other than that it's all on one line... Url.Encode and Uri.EscapeDataString seem to be two sides of the same coin blog.nerdbank.net/2009/05/uriescapedatapath-and.html I guess you've got an explanation of what's happening.. but that could have been a comment?

Jerad Rose Over a year ago

There are some differences, but the important part of my clarification, aside from the inlining, is that you didn't mention that you were trying to encode the full URL, and not just the bits that needed encoding.

Chris Nevill Over a year ago

That is what my answer does though - it does not encode the full URL. I just don't see your answer as a new answer. Just my answer with better sugar coating.

Chris Nevill Over a year ago

As a side note you've linked to the same article as me in that comment. I did read it. If anything it sounds like EscapeDataString is more RFC 3986 compliant... but in a very minimal way... I don't think that will affect the vast majority of people here.

InteXX Over a year ago

This is a good tip for encoding only parts of a URL, which is sometimes necessary and preferable over encoding it in its entirety. +1

Andrew Harry · Accepted Answer · 2014-03-18 10:27:20Z

-5

The easier method is to use @Html.Raw(Model.SomethingUrl)

answered Mar 18, 2014 at 10:27

Andrew Harry

14k18 gold badges72 silver badges103 bronze badges

Collectives™ on Stack Overflow

URL Encode string for Href ASP.NET MVC / Razor

4 Answers 4

Comments

Comments

5 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

5 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related