Expected Expression error objective c

Question

I have a chunk of code that dose not seem to work because of expected expression error.

NSMutableArray *worldData =[[NSMutableArray alloc] initWithArray:@[

                        @[ @1, @2, @3, @4,@5,@6],
                        @[ @1, @2, @3, @4,@5,@6],
                        @[ @1, @2, @3, @4,@5,@6],
                        @[ @1, @2, @3, @4,@5,@6],

                        ]];
int *x = 1;

if ( int 1 == (worldData objectAtIndex:1)){

    UIImage *block31 = [UIImage imageNamed:
                      @"grass2.png"];
}

}

James Webster · Accepted Answer · 2013-11-20 14:11:07Z

1

I don't know what this is really supposed to be:

int *x = 1;

if ( int 1 == (worldData objectAtIndex:1)){

I think you probably mean:

if ([[[worldData objectAtIndex:1] objectAtIndex:1] intValue] == 1)

or more concisely, you can use subscripts and literals:

if ([worldData[1][1]  isEqual: @1])

edited Nov 20, 2013 at 14:11

answered Nov 20, 2013 at 13:55

James Webster

32.1k11 gold badges72 silver badges116 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

James Webster Over a year ago

You're right, I did't realise direct comparison of a number literal has undefined behaviour.

Kevin DiTraglia · Accepted Answer · 2013-11-20 15:26:16Z

1

you don't need to declare the int inside the if block. Just rewrite as:

if ( 1 == [[[worldData objectAtIndex:1] objectAtIndex:1] intValue]){

edited Nov 20, 2013 at 15:26

answered Nov 20, 2013 at 13:56

Kevin DiTraglia

26.2k20 gold badges95 silver badges145 bronze badges

1 Comment

Kevin DiTraglia Over a year ago

Love fixing one problem only to notice that isn't the only problem.

Anoop Vaidya · Accepted Answer · 2013-11-20 14:16:09Z

0

int *x = 1;

Pointers are created to store address of variable.

It should be something like this:

int num = 1;
int *x = &num;

Another issue:

if ( int 1 == (worldData objectAtIndex:1)){

The above is meaningless.

As you are comparing an NSNumber value to int. Either typecast one to NSNumber or another to intValue.

if ( [@1 isEqual: worldData[1]]) //[worldData objectAtIndex:1]

or

if (1 == [worldData[1] intValue])

You are trying to access by [worldData objectAtIndex:] the complete array. So you cant compare them with an integer. Either you need another array or you need to go into deep by again going to 2nd dimension of array.

[[worldData objectAtIndex:] objectAtIndex:]

or,

worldData[row][col]

edited Nov 20, 2013 at 14:16

answered Nov 20, 2013 at 14:00

Anoop Vaidya

46.6k15 gold badges115 silver badges144 bronze badges

Collectives™ on Stack Overflow

Expected Expression error objective c

3 Answers 3

1 Comment

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related