PHP Catch Error

Question

I need to be able to catch an error. I have the following code

if($call['status_id'] != '' && $call['datetime_required'] != '')
{
   //do stuff
}
else
{
  // tell them how it failed
}

How would I go about displaying the section on which ti failed. So for example I can return a dynamic error message ie

return 'You did not fill in the field $errorField';

Where

$errorField

Is the if check on which it failed.

UPDATE

I currently code like so

if($call['status_id'] != '')
{
    if ($call['datetime_required'] != '')
    {
      //do stuff
    }
    else
    {
      // tell them it failed due to the second condition
    }
}
else
{
   // tell them it failed due to the first condition
}

But would like to do the check in one line and change the message depending on where ti failed.

Note @jack had already posted his answer before this update.

If this is in a function, you certainly can return a string that includes the error message and check to see if the return value === TRUE otherwise assume an error condition exists and the return value is the error. — Chris Rasco
– Chris Rasco, Commented Oct 3, 2013 at 15:44
Is all the data being validated stored in the class members that could be iterated through? — Chris Rasco
– Chris Rasco, Commented Oct 3, 2013 at 15:47
The database allows null fields and therefore I am validating the data before assigning it to the relevant properties and saving it in the database. I am a bit new at this btw — The Humble Rat
– The Humble Rat, Commented Oct 3, 2013 at 15:52

OneOfOne · Accepted Answer · 2013-10-03 15:43:18Z

3

I'm not sure I fully understand you, you mean something like this?

function check($call, $req_fields) {
    $failed = array();
    foreach($req_fields as $field) {
        if(!$call[$field]) {
            $failed[] = $field;
        }
    }
    if(count($failed)) {
        return join(', ', $failed) . ' are required.';
    }
    return 'success?' ;
}

$message = check($call, array('status_id', 'datetime_required'));

answered Oct 3, 2013 at 15:43

OneOfOne

100k22 gold badges195 silver badges187 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Jack · Accepted Answer · 2013-10-03 15:43:33Z

2

if($call['status_id'] != '')
{
    if ($call['datetime_required'] != '')
        //do stuff
    }
    else
    {
        // tell them it failed due to the second condition
    }
}
else
{
  // tell them it failed due to the first condition
}

answered Oct 3, 2013 at 15:43

Jack

2,8802 gold badges30 silver badges40 bronze badges

5 Comments

Chris Rasco Over a year ago

I like this solution as it provides granularity on what failed versus a blanket "failed" statement. It's more user friendly.

The Humble Rat Over a year ago

I've been doing this, but a colleague of mine recommended that this may bloat the code too much and cause too many nested if statements. So it may be better to do all the checks at once and then return the error.

Jack Over a year ago

@JonPaulH Then you should use OneOfOne's solution: stackoverflow.com/a/19163455/662761. All the fields have to be stored in an iterable for it to work.

The Humble Rat Over a year ago

Ok I thought there may be a way to catch which one it failed on. I had seen it before with pdo for example but this is obviously something to do with exceptions etc. Need to read more I think. Cheers everyone

The Humble Rat Over a year ago

I normally code as above because then I know exactly what I expect and no gremlins can get in, but someone told me otherwise (more experienced than me). Think I'll stick to this though.

Collectives™ on Stack Overflow

PHP Catch Error

2 Answers 2

Comments

5 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

5 Comments

Your Answer

Sign up or log in

Post as a guest

Related