Call method with parameters in onclick event

Question

I am trying to call method with parameter in java script onclick='addAlertDlg.show();preparePOIAlertToCreate(name)'

function preparePOIAlertToCreate(name){
    alert(name);
    document.getElementById('bottomForm:refId').value = name;       
}

But alert(name); showing nothing.

any thing wrong in my code?

Does "showing nothing" mean that an alert pops up but is blank, as might happen if your name variable is set to an empty string, or is not declared at all in which case it'll be the built-in window.name property that is quite likely an empty string? Or do you mean that nothing happens at all (no alert)? — nnnnnn
– nnnnnn, Commented Sep 25, 2013 at 7:53

Krasimir · Accepted Answer · 2013-09-25 07:36:38Z

1

Don't use inline event handling. Use the following approach:

var element = document.querySelector(".your-link-class");
element.addEventListener("click", function() {
    addAlertDlg.show();
    preparePOIAlertToCreate(name);
});
function preparePOIAlertToCreate(name){
    alert(name);
    document.getElementById('bottomForm:refId').value = name;       
}

If you do this you will find out that name is probably not defined. Also you will get a good feedback in the console.

answered Sep 25, 2013 at 7:36

Krasimir

13.6k4 gold badges45 silver badges58 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Emre Acar · Accepted Answer · 2013-09-25 07:32:20Z

0

try calling function as

onclick='addAlertDlg.show();preparePOIAlertToCreate("name")'

if you dont put 'name' in quotation marks, js will search a variable named 'name', so it cant find anything and cant show anything.

answered Sep 25, 2013 at 7:32

Emre Acar

9209 silver badges25 bronze badges

Comments

Cedric · Accepted Answer · 2013-09-25 07:37:13Z

0

The way you use the function is right, but I guess you didn't set the name any value.

answered Sep 25, 2013 at 7:37

Cedric

952 silver badges9 bronze badges

Collectives™ on Stack Overflow

Call method with parameters in onclick event

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related